From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96DEBC2B9F4 for ; Fri, 25 Jun 2021 21:11:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 705176146B for ; Fri, 25 Jun 2021 21:11:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229871AbhFYVOD (ORCPT ); Fri, 25 Jun 2021 17:14:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34092 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229776AbhFYVOC (ORCPT ); Fri, 25 Jun 2021 17:14:02 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20593C061574 for ; Fri, 25 Jun 2021 14:11:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=cX8/o+P5AkCq6YYmwi3wTfr9Bdl8j0K72iZJT1PzvrE=; b=bRfXAGOwOMopMG6okwC5t92X8P 0X8MYe6XllCE6SgkRWGa42dA+iqYGMv0Evo9ysIHd9lkGibOwGh2vOpwuREfpEcoDo2Yxf3/BjYAB 0Svd6/NyFFVglzXGPSYKPlFMAheefG009SoEWEUH8bPbNSoDPBYo0M4NVpDgbTBJQuzlKeceacx5B +Sds/zcAb/mUye6Q8goysriekKDF0OKD2Qrdd7mmzDay3JMtq+voO45D2P4d0pLwJjoJ67GxIOWvg FU90+TvPwW0UASNYUjXRdPV+MmS+BG47ugsO4UloAVq2idCIQvAydzgM+5FDISkKpVt2g3tx9QgZM IsGUZugA==; Received: from [2601:1c0:6280:3f0::aefb] by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1lwt6y-002rYH-9a; Fri, 25 Jun 2021 21:11:40 +0000 Subject: Re: [PATCH] ELF: add and use SUPRESS_WARN_UNUSED_RESULT To: Alexey Dobriyan , Miguel Ojeda Cc: Andrew Morton , linux-kernel , Miguel Ojeda References: From: Randy Dunlap Message-ID: <1de70b4e-722e-3c42-1c1d-06d6d1334206@infradead.org> Date: Fri, 25 Jun 2021 14:11:39 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/25/21 2:10 PM, Alexey Dobriyan wrote: > On Fri, Jun 25, 2021 at 10:34:29PM +0200, Miguel Ojeda wrote: >> On Fri, Jun 25, 2021 at 9:52 PM Alexey Dobriyan wrote: >>> >>> +/* >>> + * "(void)" is enough for clang but not for gcc. >>> + */ >>> +#define SUPRESS_WARN_UNUSED_RESULT (void)! >> >> While it is related to the attribute, this macro is not an attribute, >> so please add it somewhere else. > > This is natural place. If you're supressing WUR, then the WUR macro > itself is defined implying that the header has been included. > >> By the way, the name has a typo. > > Ha! > as in Aha!? s/SUPRESS/SUPPRESS/