From: Tom Zanussi <zanussi@kernel.org>
To: rostedt@goodmis.org, axelrasmussen@google.com
Cc: mhiramat@kernel.org, dan.carpenter@oracle.com,
linux-kernel@vger.kernel.org
Subject: [PATCH v7 6/6] selftests/ftrace: Add '!event' synthetic event syntax check
Date: Mon, 1 Feb 2021 13:48:16 -0600 [thread overview]
Message-ID: <1dff3f03d18542cece08c10d6323d8a8dba11e42.1612208610.git.zanussi@kernel.org> (raw)
In-Reply-To: <cover.1612208610.git.zanussi@kernel.org>
In-Reply-To: <cover.1612208610.git.zanussi@kernel.org>
Add a check confirming that '!event' alone will remove a synthetic
event.
Signed-off-by: Tom Zanussi <zanussi@kernel.org>
---
.../trigger/inter-event/trigger-synthetic-event-syntax.tc | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-synthetic-event-syntax.tc b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-synthetic-event-syntax.tc
index 59216f3cfb12..2968cdc7df30 100644
--- a/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-synthetic-event-syntax.tc
+++ b/tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger-synthetic-event-syntax.tc
@@ -32,6 +32,10 @@ grep "myevent[[:space:]]u64 var1" synthetic_events
# it is not possible to add same name event
! echo "myevent u64 var2" >> synthetic_events
+# make sure !synthetic event doesn't require a field
+echo "!myevent" >> synthetic_events
+echo "myevent u64 var1" >> synthetic_events
+
# Non-append open will cleanup all events and add new one
echo "myevent u64 var2" > synthetic_events
--
2.17.1
next prev parent reply other threads:[~2021-02-01 19:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 19:48 [PATCH v7 0/6] tracing: More synthetic event error fixes Tom Zanussi
2021-02-01 19:48 ` [PATCH v7 1/6] tracing/dynevent: Delegate parsing to create function Tom Zanussi
2021-02-01 19:48 ` [PATCH v7 2/6] tracing: Rework synthetic event command parsing Tom Zanussi
2021-02-01 19:48 ` [PATCH v7 3/6] tracing: Update synth command errors Tom Zanussi
2021-02-01 19:48 ` [PATCH v7 4/6] tracing: Add a backward-compatibility check for synthetic event creation Tom Zanussi
2021-02-01 19:48 ` [PATCH v7 5/6] selftests/ftrace: Update synthetic event syntax errors Tom Zanussi
2021-02-01 19:48 ` Tom Zanussi [this message]
2021-02-09 21:09 ` [PATCH v7 0/6] tracing: More synthetic event error fixes Steven Rostedt
2021-02-09 22:58 ` Tom Zanussi
2021-02-10 1:21 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1dff3f03d18542cece08c10d6323d8a8dba11e42.1612208610.git.zanussi@kernel.org \
--to=zanussi@kernel.org \
--cc=axelrasmussen@google.com \
--cc=dan.carpenter@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).