From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: zhong jiang <zhongjiang@huawei.com>, davem@davemloft.net
Cc: benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2] ide: Use NULL to compare with pointer-typed value rather than 0
Date: Sat, 18 Aug 2018 19:25:47 +0300 [thread overview]
Message-ID: <1e17b3d3-4e5a-7318-e6f6-c8da311e26c8@cogentembedded.com> (raw)
In-Reply-To: <8badfdf8-ce69-1722-a489-fee161a1f4aa@cogentembedded.com>
On 08/18/2018 06:53 PM, Sergei Shtylyov wrote:
>> We should use NULL to compare with pointer-typed value rather than
>> 0. The issue is detected with the help of Coccinelle.
>
> Your description stopped to match the patch in v2.
And your subject as well...
> Actually, this X == NULL to !x preference is largely spocific to netdev...
Specific, of course. :-)
> Although, IDE maintainer is the same now person. :-)
"The same person now" I wanted to type. :-)
>
>> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
[...]
MBR, Sergei
prev parent reply other threads:[~2018-08-18 16:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-18 6:16 [PATCHv2] ide: Use NULL to compare with pointer-typed value rather than 0 zhong jiang
2018-08-18 15:53 ` Sergei Shtylyov
2018-08-18 16:15 ` Joe Perches
2018-08-18 16:21 ` Sergei Shtylyov
2018-08-18 16:26 ` Joe Perches
2018-08-18 16:25 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e17b3d3-4e5a-7318-e6f6-c8da311e26c8@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).