From: Michal Simek <michal.simek@amd.com>
To: "Katakam, Harini" <harini.katakam@amd.com>,
"vkoul@kernel.org" <vkoul@kernel.org>,
"romain.perier@gmail.com" <romain.perier@gmail.com>,
"allen.lkml@gmail.com" <allen.lkml@gmail.com>,
"yukuai3@huawei.com" <yukuai3@huawei.com>
Cc: "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"harinikatakamlinux@gmail.com" <harinikatakamlinux@gmail.com>,
"Pandey, Radhey Shyam" <radhey.shyam.pandey@amd.com>
Subject: Re: [PATCH] dmaengine: zynqmp_dma: Sync DMA and coherent masks
Date: Tue, 21 Mar 2023 16:15:55 +0100 [thread overview]
Message-ID: <1e44aa00-9896-8869-1707-fe8e5815e9c7@amd.com> (raw)
In-Reply-To: <BYAPR12MB47737C53AA67606A94B223C59E819@BYAPR12MB4773.namprd12.prod.outlook.com>
On 3/21/23 16:04, Katakam, Harini wrote:
> Hi Michal,
>
>> -----Original Message-----
>> From: Simek, Michal <michal.simek@amd.com>
>> Sent: Tuesday, March 21, 2023 8:15 PM
>> To: Katakam, Harini <harini.katakam@amd.com>; vkoul@kernel.org;
>> romain.perier@gmail.com; allen.lkml@gmail.com; yukuai3@huawei.com
>> Cc: dmaengine@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
>> kernel@vger.kernel.org; harinikatakamlinux@gmail.com; Pandey, Radhey
>> Shyam <radhey.shyam.pandey@amd.com>
>> Subject: Re: [PATCH] dmaengine: zynqmp_dma: Sync DMA and coherent
>> masks
>>
>>
>>
>> On 3/16/23 10:33, Harini Katakam wrote:
>>> Align ZDMA DMA as well as coherent memory masks to 44 bit. This is
>>> required when using >32 bit memory regions.
>>
>> It doesn't look like description aligned with the change below.
>> You are using 44 bit already and the patch itself just checking return value
>> from that function.
>
> Current code sets dma_set_mask; I changed it to dma_set_mask_and_coherent
Ah ok. Then
Acked-by: Michal Simek <michal.simek@amd.com>
Thanks,
Michal
next prev parent reply other threads:[~2023-03-21 15:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 9:33 [PATCH] dmaengine: zynqmp_dma: Sync DMA and coherent masks Harini Katakam
2023-03-21 14:45 ` Michal Simek
2023-03-21 15:04 ` Katakam, Harini
2023-03-21 15:15 ` Michal Simek [this message]
2023-03-31 12:24 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e44aa00-9896-8869-1707-fe8e5815e9c7@amd.com \
--to=michal.simek@amd.com \
--cc=allen.lkml@gmail.com \
--cc=dmaengine@vger.kernel.org \
--cc=harini.katakam@amd.com \
--cc=harinikatakamlinux@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=radhey.shyam.pandey@amd.com \
--cc=romain.perier@gmail.com \
--cc=vkoul@kernel.org \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).