From: "Noralf Trønnes" <noralf@tronnes.org>
To: Dillon Min <dillon.minfei@gmail.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>, Dave Airlie <airlied@linux.ie>,
Daniel Vetter <daniel@ffwll.ch>, Rob Herring <robh+dt@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre TORGUE <alexandre.torgue@foss.st.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Doug Anderson <dianders@chromium.org>,
linux-stm32@st-md-mailman.stormreply.com,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
"open list:DRM PANEL DRIVERS" <dri-devel@lists.freedesktop.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] drm/panel: Add ilitek ili9341 panel driver
Date: Thu, 22 Jul 2021 09:03:41 +0200 [thread overview]
Message-ID: <1e4743b0-250f-975a-f83d-5d000c6496e3@tronnes.org> (raw)
In-Reply-To: <CAL9mu0K2yLsG0MXOd4ke8N8zn7311CJ54hL-JcbocJOK+H7W9A@mail.gmail.com>
Den 22.07.2021 04.07, skrev Dillon Min:
> Hi Noralf
>
> Thanks for your time to review my patch.
>
> On Thu, 22 Jul 2021 at 01:42, Noralf Trønnes <noralf@tronnes.org> wrote:
>>
>>
>>
>> Den 21.07.2021 09.41, skrev dillon.minfei@gmail.com:
>>> From: Dillon Min <dillon.minfei@gmail.com>
>>>
>>> This driver combine tiny/ili9341.c mipi_dbi_interface driver
>>> with mipi_dpi_interface driver, can support ili9341 with serial
>>> mode or parallel rgb interface mode by register configuration.
>>>
>>> Cc: Linus Walleij <linus.walleij@linaro.org>
>>> Signed-off-by: Dillon Min <dillon.minfei@gmail.com>
>>> ---
>>
>>> +static const struct of_device_id ili9341_of_match[] = {
>>> + {
>>> + .compatible = "st,sf-tc240t-9370-t",
>>> + .data = &ili9341_stm32f429_disco_data,
>>> + },
>>> + {
>>> + /* porting from tiny/ili9341.c
>>> + * for original mipi dbi compitable
>>> + */
>>> + .compatible = "adafruit,yx240qv29",
>>
>> I don't understand this, now there will be 2 drivers that support the
>> same display?
>
> There is no reason to create two drivers to support the same display.
>
> To support only-dbi and dbi+dpi panel at drm/panel or drm/tiny both
> fine with me.
>
>>
>> AFAICT drm/tiny/ili9341.c is just copied into this driver, is the plan
>> to remove the tiny/ driver? If so I couldn't see this mentioned anywhere.
>
> Yes, I'd like to merge the code from drm/tiny/ili9341.c to this driver
> (to make a single driver to support different bus).
>
> I have two purpose to extend the feature drm/tiny/ili9341.c
>
> - keep compatible = "adafruit,yx240qv29", add bus mode dts bindings (panel_bus)
> to define the interface which host wants to use. such as
> panel_bus="dbi" or "rgb"
> or "i80" for this case, i will add dpi code to drm/tiny/ili9341.c.
>
> - merge tiny/ili9341.c to this driver,remove drm/tiny/ili9341.c, add
> new dts compatible
> string to support other interfaces. just like what i'm doing now.
>
> I have no idea about your plan on drm/tiny drivers, actually some of
> these panels under
> the diny folder can support both dbi and dbi+dpi (much faster, need
> more pins). no
> doubt the requirement to support dpi is always there.
>
> What is your preference?
>
I have no plans for tiny/, it's just a place to put tiny DRM drivers of
all sorts.
Whether or not to have "full" DRM drivers in panel/ is up to Sam and
Laurent I guess, currently there's only drm_panel drivers in there. I
have no objections to doing that though.
I just wanted to make sure we don't have 2 drivers for the same display.
Noralf.
> Thanks & Regards
> Dillon
>
>>
>> Noralf.
>>
>>> + .data = NULL,
>>> + },
>>> +};
>>> +MODULE_DEVICE_TABLE(of, ili9341_of_match);
next prev parent reply other threads:[~2021-07-22 7:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 7:41 [PATCH v2 0/3] Add ilitek ili9341 panel driver dillon.minfei
2021-07-21 7:41 ` [PATCH v2 1/3] dt-bindings: display: panel: Add ilitek ili9341 panel bindings dillon.minfei
2021-07-21 14:00 ` Linus Walleij
[not found] ` <YPgsl5M6P86iJADt@ravnborg.org>
2021-07-21 14:22 ` Linus Walleij
2021-07-21 7:41 ` [PATCH v2 2/3] ARM: dts: stm32: fix dtbs_check warning on ili9341 dts binding dillon.minfei
2021-07-21 14:53 ` Dillon Min
2021-07-21 7:41 ` [PATCH v2 3/3] drm/panel: Add ilitek ili9341 panel driver dillon.minfei
2021-07-21 14:02 ` Linus Walleij
2021-07-21 15:00 ` Dillon Min
2021-07-21 15:47 ` Jagan Teki
2021-07-21 23:08 ` Dillon Min
2021-07-22 7:58 ` Jagan Teki
2021-07-21 17:42 ` Noralf Trønnes
2021-07-22 2:07 ` Dillon Min
2021-07-22 7:03 ` Noralf Trønnes [this message]
2021-07-22 7:10 ` Dillon Min
[not found] ` <YPhR1citK6Nodep/@ravnborg.org>
2021-07-21 23:28 ` Dillon Min
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e4743b0-250f-975a-f83d-5d000c6496e3@tronnes.org \
--to=noralf@tronnes.org \
--cc=airlied@linux.ie \
--cc=alexandre.torgue@foss.st.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dillon.minfei@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).