From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754023AbcL3Nuv (ORCPT ); Fri, 30 Dec 2016 08:50:51 -0500 Received: from mail-wj0-f196.google.com ([209.85.210.196]:36039 "EHLO mail-wj0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751854AbcL3Nut (ORCPT ); Fri, 30 Dec 2016 08:50:49 -0500 Subject: Re: [PATCH 1/5] [media] ir-rx51: port to rc-core To: Sean Young References: <5878d916-6a60-d5c3-b912-948b5b970661@gmail.com> <20161230130752.GA7377@gofer.mess.org> <20161230133030.GA7861@gofer.mess.org> Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Timo Kokkonen , Pavel Machek , =?UTF-8?Q?Pali_Roh=c3=a1r?= From: Ivaylo Dimitrov Message-ID: <1e4fa726-5dec-028e-9f0f-1c53d58df981@gmail.com> Date: Fri, 30 Dec 2016 15:50:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161230133030.GA7861@gofer.mess.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30.12.2016 15:30, Sean Young wrote: > > On Fri, Dec 30, 2016 at 01:07:52PM +0000, Sean Young wrote: >> Hi Ivo,, >> >> On Fri, Dec 30, 2016 at 01:30:01PM +0200, Ivaylo Dimitrov wrote: >>> On 20.12.2016 19:50, Sean Young wrote: >>>> This driver was written using lirc since rc-core did not support >>>> transmitter-only hardware at that time. Now that it does, port >>>> this driver. >>>> >>>> Compile tested only. >>>> >>> >>> I guess after that change, there will be no more /dev/lircN device, right? >>> Neither will LIRC_XXX IOCTL codes be supported? >> >> Quite the opposite, /dev/lircN and all the LIRC_XXX ioctls will still be >> supported through ir-lirc-codec.c. >> >> By using rc-core, the driver will be more succinct, and some latent bugs >> will be fixed. For example, at the moment it is possible to write hours >> of IR data and keep the n900 from suspending. >> >> I'm working on lirc scancode sending and receiving using the IR encoders, >> and when that is in place, any rc-core driver will get it for free. >> >>> That looks to me as a completely new driver, not a port to new API. >>> >>> Right now there are applications using the current behaviour (pierogi for >>> example), which will be broken by the change. >> >> Nothing should break. > > Speaking of which, if you would please test this, that would be great. My > N900 died many years ago. > Will do, but next year :) . Thanks, Ivo