From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967372AbdADJdN convert rfc822-to-8bit (ORCPT ); Wed, 4 Jan 2017 04:33:13 -0500 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:56912 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S967229AbdADJcl (ORCPT ); Wed, 4 Jan 2017 04:32:41 -0500 From: Vincent ABRIOU To: Arvind Yadav , "benjamin.gaignard@linaro.org" , "airlied@linux.ie" CC: "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" Subject: Re: [v1] gpu: drm: sti: sti_vtac:- Handle return NULL error from devm_ioremap_nocache Thread-Topic: [v1] gpu: drm: sti: sti_vtac:- Handle return NULL error from devm_ioremap_nocache Thread-Index: AQHSW0pHnXmyhQZdwUWET0I8AJhZqaEoE1uA Date: Wed, 4 Jan 2017 09:31:40 +0000 Message-ID: <1e787556-a90a-5ccf-29b8-e791f4063ebf@st.com> References: <1482297755-4620-1-git-send-email-arvind.yadav.cs@gmail.com> In-Reply-To: <1482297755-4620-1-git-send-email-arvind.yadav.cs@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.47] Content-Type: text/plain; charset="Windows-1252" Content-ID: Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-01-04_07:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arvind, Thank for this patch. Since sti_vtac.c file is deprecated, I rather suppress the sti_vtac.c file. I just push a new patch to suppress it. Thank for pointing this out. Br Vincent On 12/21/2016 06:22 AM, Arvind Yadav wrote: > Here, If devm_ioremap_nocache will fail. It will return NULL. > Kernel can run into a NULL-pointer dereference. This error check > will avoid NULL pointer dereference. > > Signed-off-by: Arvind Yadav > --- > drivers/gpu/drm/sti/sti_vtac.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/sti/sti_vtac.c b/drivers/gpu/drm/sti/sti_vtac.c > index cf7fe8a..dd749e9 100644 > --- a/drivers/gpu/drm/sti/sti_vtac.c > +++ b/drivers/gpu/drm/sti/sti_vtac.c > @@ -191,6 +191,10 @@ static int sti_vtac_probe(struct platform_device *pdev) > if (res) { > vtac->phy_regs = devm_ioremap_nocache(dev, res->start, > resource_size(res)); > + if (!vtac->phy_regs) { > + DRM_ERROR("failed to remap I/O memory\n"); > + return -ENOMEM; > + } > sti_vtac_tx_set_config(vtac); > } else { > >