From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: Qais Yousef <qais.yousef@arm.com>, vincent.donnefort@arm.com
Cc: mingo@redhat.com, peterz@infradead.org,
vincent.guittot@linaro.org, linux-kernel@vger.kernel.org,
valentin.schneider@arm.com
Subject: Re: [PATCH v2] sched/debug: Add new tracepoint to track cpu_capacity
Date: Fri, 28 Aug 2020 19:10:41 +0200 [thread overview]
Message-ID: <1e806d48-fd54-fd86-5b3a-372d9876f360@arm.com> (raw)
In-Reply-To: <20200828102724.wmng7p6je2pkc33n@e107158-lin.cambridge.arm.com>
On 28/08/2020 12:27, Qais Yousef wrote:
> On 08/28/20 10:00, vincent.donnefort@arm.com wrote:
>> From: Vincent Donnefort <vincent.donnefort@arm.com>
>>
>> rq->cpu_capacity is a key element in several scheduler parts, such as EAS
>> task placement and load balancing. Tracking this value enables testing
>> and/or debugging by a toolkit.
>>
>> Signed-off-by: Vincent Donnefort <vincent.donnefort@arm.com>
>>
>> diff --git a/include/linux/sched.h b/include/linux/sched.h
>
> [...]
>
>> +int sched_trace_rq_cpu_capacity(struct rq *rq)
>> +{
>> + return rq ?
>> +#ifdef CONFIG_SMP
>> + rq->cpu_capacity
>> +#else
>> + SCHED_CAPACITY_SCALE
>> +#endif
>> + : -1;
>> +}
>> +EXPORT_SYMBOL_GPL(sched_trace_rq_cpu_capacity);
>> +
>
> The placement of this #ifdef looks odd to me. But FWIW
>
> Reviewed-by: Qais Yousef <qais.yousef@arm.com>
Returning -1 for cpu_capacity? It makes sense for sched_trace_rq_cpu()
but for cpu_capacity?
Can you remind me why we have all these helper functions like
sched_trace_rq_cpu_capacity?
In case we would let the extra code (which transforms trace points into
trace events) know the internals of struct rq we could handle those
things in the TRACE_EVENT and/or the register_trace_##name(void
(*probe)(data_proto), void *data) thing.
We always said when the internal things will change this extra code will
break. So that's not an issue.
next prev parent reply other threads:[~2020-08-28 17:10 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-28 9:00 [PATCH v2] sched/debug: Add new tracepoint to track cpu_capacity vincent.donnefort
2020-08-28 10:27 ` Qais Yousef
2020-08-28 17:10 ` Dietmar Eggemann [this message]
2020-08-28 17:26 ` Qais Yousef
2020-09-02 10:44 ` Dietmar Eggemann
2020-09-02 13:54 ` Phil Auld
2020-09-07 11:02 ` Qais Yousef
2020-09-08 13:19 ` Phil Auld
2020-09-08 15:22 ` Qais Yousef
2021-01-04 18:26 ` Qais Yousef
2021-01-04 18:59 ` Alexei Starovoitov
2021-01-05 11:38 ` Qais Yousef
2021-01-05 16:44 ` Alexei Starovoitov
2021-01-06 11:27 ` Qais Yousef
2021-01-06 23:42 ` Andrii Nakryiko
2021-01-07 11:23 ` Qais Yousef
2021-01-11 14:04 ` Peter Zijlstra
2021-01-11 14:08 ` Qais Yousef
2020-09-07 10:48 ` Qais Yousef
2020-09-07 11:13 ` peterz
2020-09-07 14:51 ` Qais Yousef
2020-09-08 11:17 ` Dietmar Eggemann
2020-09-08 15:17 ` Qais Yousef
2020-09-08 16:17 ` Dietmar Eggemann
2021-01-04 15:18 ` Qais Yousef
2020-10-05 7:43 ` [tip: sched/core] " tip-bot2 for Vincent Donnefort
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e806d48-fd54-fd86-5b3a-372d9876f360@arm.com \
--to=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=qais.yousef@arm.com \
--cc=valentin.schneider@arm.com \
--cc=vincent.donnefort@arm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).