From: Jia-Ju Bai <baijiaju1990@gmail.com>
To: mlindner@marvell.com, stephen@networkplumber.org,
shemminger@osdl.org, shemminger@linux-foundation.org
Cc: netdev@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [BUG] skge: a possible sleep-in-atomic bug in skge_remove
Date: Tue, 12 Dec 2017 16:38:12 +0800 [thread overview]
Message-ID: <1e8a8196-f0d1-2a82-3632-b882787c4391@gmail.com> (raw)
According to drivers/net/ethernet/marvell/skge.c, the driver may sleep
under a spinlock.
The function call path is:
skge_remove (acquire the spinlock)
free_irq --> may sleep
I do not find a good way to fix it, so I only report.
This possible bug is found by my static analysis tool (DSAC) and checked
by my code review.
Thanks,
Jia-Ju Bai
next reply other threads:[~2017-12-12 8:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 8:38 Jia-Ju Bai [this message]
2017-12-12 13:34 ` [BUG] skge: a possible sleep-in-atomic bug in skge_remove David Miller
2017-12-12 18:22 ` Stephen Hemminger
2017-12-13 1:57 ` David Miller
2017-12-13 5:18 ` Stephen Hemminger
2017-12-13 7:42 ` Jia-Ju Bai
2017-12-13 16:50 ` Stephen Hemminger
2017-12-14 3:06 ` Jia-Ju Bai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e8a8196-f0d1-2a82-3632-b882787c4391@gmail.com \
--to=baijiaju1990@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mlindner@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
--cc=shemminger@osdl.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).