From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754200AbdEQJVw (ORCPT ); Wed, 17 May 2017 05:21:52 -0400 Received: from regular1.263xmail.com ([211.150.99.135]:46758 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753807AbdEQJVt (ORCPT ); Wed, 17 May 2017 05:21:49 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-RL-SENDER: frank.wang@rock-chips.com X-FST-TO: wmc@rock-chips.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: frank.wang@rock-chips.com X-UNIQUE-TAG: <7ca2d510c13079245e51dbbd76ce3318> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH 1/3] arm: dts: rk322x: fix i2s1 pinctrl error To: =?UTF-8?Q?Heiko_St=c3=bcbner?= Cc: robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, charles.chen@rock-chips.com, cody.xie@rock-chips.com, kevan.lan@rock-chips.com, huangtao@rock-chips.com, sugar.zhang@rock-chips.com, wmc@rock-chips.com References: <1494992451-32542-1-git-send-email-frank.wang@rock-chips.com> <1494992451-32542-2-git-send-email-frank.wang@rock-chips.com> <2781249.GNsgFIKA50@diego> From: Frank Wang Message-ID: <1e922ff2-d1ce-5bff-e172-3b2ddf713d9e@rock-chips.com> Date: Wed, 17 May 2017 17:21:01 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <2781249.GNsgFIKA50@diego> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Heiko, On 2017/5/17 17:01, Heiko Stübner wrote: > Hi Frank, > > Am Mittwoch, 17. Mai 2017, 11:40:49 CEST schrieb Frank Wang: >> From: Sugar Zhang >> >> Refer to Chapter 5.3.2 of rk3229 TRM, we can see that GPIO1A[2,4,5] >> using RK_FUNC_2 not RK_FUNC_1. This patch fixes it. >> >> Signed-off-by: Frank Wang > if the patch has another author, you should preserve his/her Signed-off-by > line, so for example this patch would look like: > > Signed-off-by: Sugar Zhang > Signed-off-by: Frank Wang > > Same for all other patches with differing authors in your 2 series from > today. As this touches the developer-certificate-of-origin, this is also > something I cannot really correct myself. Noted and thanks for reminding, I will resend these 2 series. BR. Frank > > Heiko > > >> --- >> arch/arm/boot/dts/rk322x.dtsi | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/arch/arm/boot/dts/rk322x.dtsi b/arch/arm/boot/dts/rk322x.dtsi >> index 48a0c1c..cc6a27d 100644 >> --- a/arch/arm/boot/dts/rk322x.dtsi >> +++ b/arch/arm/boot/dts/rk322x.dtsi >> @@ -621,9 +621,9 @@ >> <0 12 RK_FUNC_1 &pcfg_pull_none>, >> <0 13 RK_FUNC_1 &pcfg_pull_none>, >> <0 14 RK_FUNC_1 &pcfg_pull_none>, >> - <1 2 RK_FUNC_1 &pcfg_pull_none>, >> - <1 4 RK_FUNC_1 &pcfg_pull_none>, >> - <1 5 RK_FUNC_1 &pcfg_pull_none>; >> + <1 2 RK_FUNC_2 &pcfg_pull_none>, >> + <1 4 RK_FUNC_2 &pcfg_pull_none>, >> + <1 5 RK_FUNC_2 &pcfg_pull_none>; >> }; >> }; > > > >