linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@intel.com>
To: Andy Lutomirski <luto@kernel.org>,
	"Robert O'Callahan" <robert@ocallahan.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	X86 ML <x86@kernel.org>
Subject: Re: xgetbv nondeterminism
Date: Thu, 15 Jun 2017 07:33:18 -0700	[thread overview]
Message-ID: <1eb55c22-6c90-e1b3-19d4-cb7b2c6fc0dc@intel.com> (raw)
In-Reply-To: <CALCETrXfTcJaRjetDP=+nAY9qurfKKFpKnGaCxjye66JKkCzaQ@mail.gmail.com>

On 06/14/2017 10:18 PM, Andy Lutomirski wrote:
> Dave, why is XINUSE exposed at all to userspace?

You need it for XSAVEOPT when it is using the init optimization to be
able to tell which state was written and which state in the XSAVE buffer
is potentially stale with respect to what's in the registers.  I guess
you can just use XSAVE instead of XSAVEOPT, though.

As you pointed out, if you are using XSAVEC's compaction features by
leaving bits unset in the requested feature bitmap registers, you have
no idea how much data XSAVEC will write, unless you read XINUSE with
XGETBV.  But, you can get around *that* by just presizing the XSAVE
buffer to be big.

So, I guess that leaves its use to just figuring out how much XSAVEOPT
(and friends) are going to write.

> To be fair, glibc uses this new XGETBV feature, but I suspect its
> usage is rather dubious.  Shouldn't it just do XSAVEC directly rather
> than rolling its own code?

A quick grep through my glibc source only shows XGETBV(0) used which
reads XCR0.  I don't see any XGETBV(1) which reads XINUSE.  Did I miss it.

  reply	other threads:[~2017-06-15 14:33 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-15  5:18 xgetbv nondeterminism Andy Lutomirski
2017-06-15 14:33 ` Dave Hansen [this message]
2017-06-15 22:18   ` Andy Lutomirski
2017-06-15 22:40     ` H.J. Lu
2017-06-15 22:45       ` Andy Lutomirski
2017-06-15 23:11         ` H.J. Lu
2017-06-15 23:28           ` Andy Lutomirski
2017-06-16  2:17             ` H.J. Lu
2017-06-16  3:05               ` Andy Lutomirski
2017-06-16  4:34                 ` H.J. Lu
2017-06-16 16:01                   ` Andy Lutomirski
2017-06-16 16:17                     ` H.J. Lu
2017-06-16 16:38                       ` Andy Lutomirski
2017-06-16 17:44                         ` H.J. Lu
2017-06-16 17:56                           ` Andy Lutomirski
2017-06-16 18:03                             ` H.J. Lu
2017-06-17  6:21                               ` Andy Lutomirski
2017-06-17 12:51                                 ` H.J. Lu
2017-06-17 16:32                                   ` Andy Lutomirski
2017-06-17 19:48                                     ` H.J. Lu
2017-06-15 23:37     ` Dave Hansen
2017-06-16  2:28       ` H.J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1eb55c22-6c90-e1b3-19d4-cb7b2c6fc0dc@intel.com \
    --to=dave.hansen@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=robert@ocallahan.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).