From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F4F2C4338F for ; Tue, 10 Aug 2021 14:25:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6C24560FC4 for ; Tue, 10 Aug 2021 14:25:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241814AbhHJOZb (ORCPT ); Tue, 10 Aug 2021 10:25:31 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:48387 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243568AbhHJOYU (ORCPT ); Tue, 10 Aug 2021 10:24:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628605438; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F7NGeCuOaubYuz/1ug/TSUdVrfsBtP6E2aZrsDudCso=; b=Ms/028kDqtyKBiPIQEdFIQQHSNmtl3cdIeGGZDXDBiVXMqhyOjnUGpjOl5p/mGc2ppMsV6 26dJ9GylDnzVIuJd5dnmG/VbcFctKbnTyXmLFAKvk1S3NL+c1z3WOf8o3tYLe3qNj3bO8Q EOjc0TlSrpjO4ZUpKNlfUppD3Du+mAg= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-560-XvWfREvkMM26OHyY4sSM-Q-1; Tue, 10 Aug 2021 10:23:57 -0400 X-MC-Unique: XvWfREvkMM26OHyY4sSM-Q-1 Received: by mail-wr1-f69.google.com with SMTP id d12-20020a056000186cb02901548bff164dso6475016wri.18 for ; Tue, 10 Aug 2021 07:23:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:cc:subject:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=F7NGeCuOaubYuz/1ug/TSUdVrfsBtP6E2aZrsDudCso=; b=pNzoO7fnlpfqV15tCyDtlPg1KJAUjxFB6qkYdo9mxHkqXaV2DKlUKMyhlzI13lPrAn 9ZCC//kNoEoZtJdkcAWHJGApBEbh7DSRI6vQc7wxcEvJV8DhQWcMlLPsbpIyhC/AMcWb /Il1OoxkVKRm2W2N92w0NwVKu4vEBevLCJpa2meiBltF+i51rxnMLMgLcwlC7Dapt2lJ PQxGSWzq1dvDitIdtf96y/TKqDUsqHhLVnmVHJrV4395l9kfW1sjR69zIHMs5KV1bLlq piGiPODpbQP23lkFXcQPXZ6AK+8OJfLlONVIBZeFlnefActmB9q9ElJfMg3jQBpr4X/q Dd4A== X-Gm-Message-State: AOAM533qCayqqGZn5y2JHyooQUPTCA8U1/itFmradXlSnjLitCpAN7QE 8T3dr4miQy72w29OEJXxIwYkk93ksvyPutKAxI869cU4u7pn1HqHrunSNOXOOqZp57g3Ki6fspP Ggmn32ZqwkMEpzh8kzlHQW3hV X-Received: by 2002:adf:f4c5:: with SMTP id h5mr31939769wrp.292.1628605435929; Tue, 10 Aug 2021 07:23:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxU5KywGRiCQymuIhkLmnRCVk61+rHhGXtUMqK/2zRivVoqzIKMeSsCmj59NACGItvmK39weg== X-Received: by 2002:adf:f4c5:: with SMTP id h5mr31939741wrp.292.1628605435752; Tue, 10 Aug 2021 07:23:55 -0700 (PDT) Received: from [192.168.42.238] (3-14-107-185.static.kviknet.dk. [185.107.14.3]) by smtp.gmail.com with ESMTPSA id d4sm9044243wrc.34.2021.08.10.07.23.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Aug 2021 07:23:55 -0700 (PDT) From: Jesper Dangaard Brouer X-Google-Original-From: Jesper Dangaard Brouer Cc: brouer@redhat.com, davem@davemloft.net, alexander.duyck@gmail.com, linux@armlinux.org.uk, mw@semihalf.com, linuxarm@openeuler.org, yisen.zhuang@huawei.com, salil.mehta@huawei.com, thomas.petazzoni@bootlin.com, hawk@kernel.org, ilias.apalodimas@linaro.org, ast@kernel.org, daniel@iogearbox.net, john.fastabend@gmail.com, akpm@linux-foundation.org, peterz@infradead.org, will@kernel.org, willy@infradead.org, vbabka@suse.cz, fenghua.yu@intel.com, guro@fb.com, peterx@redhat.com, feng.tang@intel.com, jgg@ziepe.ca, mcroce@microsoft.com, hughd@google.com, jonathan.lemon@gmail.com, alobakin@pm.me, willemb@google.com, wenxu@ucloud.cn, cong.wang@bytedance.com, haokexin@gmail.com, nogikh@google.com, elver@google.com, yhs@fb.com, kpsingh@kernel.org, andrii@kernel.org, kafai@fb.com, songliubraving@fb.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, chenhao288@hisilicon.com, Linux-MM Subject: Re: [PATCH net-next v2 0/4] add frag page support in page pool To: Jakub Kicinski , Yunsheng Lin References: <1628217982-53533-1-git-send-email-linyunsheng@huawei.com> <20210810070159.367e680e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Message-ID: <1eb903a5-a954-e405-6088-9b9209703f5e@redhat.com> Date: Tue, 10 Aug 2021 16:23:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210810070159.367e680e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/08/2021 16.01, Jakub Kicinski wrote: > On Fri, 6 Aug 2021 10:46:18 +0800 Yunsheng Lin wrote: >> enable skb's page frag recycling based on page pool in >> hns3 drvier. > > Applied, thanks! I had hoped to see more acks / reviewed-by before this got applied. E.g. from MM-people as this patchset changes struct page and page_pool (that I'm marked as maintainer of). And I would have appreciated an reviewed-by credit to/from Alexander as he did a lot of work in the RFC patchset for the split-page tricks. p.s. I just returned from vacation today, and have not had time to review, sorry. --Jesper (relevant struct page changes for MM-people to review) diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h index 52bbd2b..7f8ee09 100644 --- a/include/linux/mm_types.h +++ b/include/linux/mm_types.h @@ -103,11 +103,19 @@ struct page { unsigned long pp_magic; struct page_pool *pp; unsigned long _pp_mapping_pad; - /** - * @dma_addr: might require a 64-bit value on - * 32-bit architectures. - */ - unsigned long dma_addr[2]; + unsigned long dma_addr; + union { + /** + * dma_addr_upper: might require a 64-bit + * value on 32-bit architectures. + */ + unsigned long dma_addr_upper; + /** + * For frag page support, not supported in + * 32-bit architectures with 64-bit DMA. + */ + atomic_long_t pp_frag_count; + }; }; struct { /* slab, slob and slub */