From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 017EAC433DB for ; Wed, 3 Feb 2021 10:09:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A8F2B6024A for ; Wed, 3 Feb 2021 10:09:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233678AbhBCKIz (ORCPT ); Wed, 3 Feb 2021 05:08:55 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:37396 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233336AbhBCKIv (ORCPT ); Wed, 3 Feb 2021 05:08:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612346844; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RRNWNZSEjYUISWzV/hzDQuuQn4Ann7n4iPTKBGa+3mE=; b=PNWeULNwzBb6eQcoGYRPgAsWOnQVkQyJ8vD33ZOgRvnQXmNymoT4Zkr/V5d03ubN3oZ4XM EM7ptoPEUfQ4sw/UOGYOsZ680OGhgC4h2o84M3bqTdnUMPNJtMOyQnnXhhwbU2lxbCJz19 EapA66SXzytVDYJQy+3rKP2ONJBhVsk= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-213-0Wu1dzYoNoy0kTaRJ3qmHA-1; Wed, 03 Feb 2021 05:07:20 -0500 X-MC-Unique: 0Wu1dzYoNoy0kTaRJ3qmHA-1 Received: by mail-ed1-f72.google.com with SMTP id m18so11128947edp.13 for ; Wed, 03 Feb 2021 02:07:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=RRNWNZSEjYUISWzV/hzDQuuQn4Ann7n4iPTKBGa+3mE=; b=ICZ8JTh13lsT7R6q3xSEKZ3SA9oBuGXRDJP96WsM+Y7Nvgc+IrSs0PPdnMgE+GBk+m HRQuL5XC+OO7jlofZDWwn86eRuBO80pQsL9c7QJ6VeNsZCxSxPFsfMFNWa5euvlDT+pP s2j6pp5ZCJvSH1r4DzVnLcB/FZTeFZKsd0Nkoc9CtNMX27K7CPmCrCCH9uG56PRSNPAK 5ZZJ2R3i1u4XLhkLiUiJbCyIbCsd3FVwUuDWrzIslKIOg2eTTZbSfdIEI4mFF5Ktt9hb vFIsBfwtNfXmdVb0TIa1G8shNobUiWlFAw5Goyl1eeOFXXEgKtmP+yrLVeHe5OU5dFXz fRrg== X-Gm-Message-State: AOAM533DHs+/1Y+4I0G7hhzQ3ReJVwk44LKEnKVV9rAMjf5+2N3Q+Ynd O9yJ1HyyhZ5E6Dr1DHJvVlFSservFEmG56xeI/e2yJw/GBVrxt6uKN/KMLufawLTKGV0RnIB2TG 3dj01NQW8pMWHnTXfhn6hb/Nb X-Received: by 2002:a05:6402:1118:: with SMTP id u24mr2157679edv.386.1612346839148; Wed, 03 Feb 2021 02:07:19 -0800 (PST) X-Google-Smtp-Source: ABdhPJyNBYEODxX2CDv6VeeoBShNHoVFAtymdsHrukNbtazorn38PHHEcvCDODPGT2aOTgYsyvAhjg== X-Received: by 2002:a05:6402:1118:: with SMTP id u24mr2157652edv.386.1612346838998; Wed, 03 Feb 2021 02:07:18 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id h25sm781475ejy.7.2021.02.03.02.07.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Feb 2021 02:07:18 -0800 (PST) Subject: Re: [PATCH v2 28/28] KVM: selftests: Disable dirty logging with vCPUs running To: Ben Gardon , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: Peter Xu , Sean Christopherson , Peter Shier , Peter Feiner , Junaid Shahid , Jim Mattson , Yulei Zhang , Wanpeng Li , Vitaly Kuznetsov , Xiao Guangrong , Andrew Jones , Thomas Huth References: <20210202185734.1680553-1-bgardon@google.com> <20210202185734.1680553-29-bgardon@google.com> From: Paolo Bonzini Message-ID: <1edd4e34-5463-9802-bf07-7f4840f3d103@redhat.com> Date: Wed, 3 Feb 2021 11:07:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210202185734.1680553-29-bgardon@google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/02/21 19:57, Ben Gardon wrote: > Disabling dirty logging is much more intestesting from a testing > perspective if the vCPUs are still running. This also excercises the > code-path in which collapsible SPTEs must be faulted back in at a higher > level after disabling dirty logging. > > To: linux-kselftest@vger.kernel.org > CC: Peter Xu > CC: Andrew Jones > CC: Thomas Huth > Signed-off-by: Ben Gardon > --- > tools/testing/selftests/kvm/dirty_log_perf_test.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/tools/testing/selftests/kvm/dirty_log_perf_test.c b/tools/testing/selftests/kvm/dirty_log_perf_test.c > index 604ccefd6e76..d44a5b8ef232 100644 > --- a/tools/testing/selftests/kvm/dirty_log_perf_test.c > +++ b/tools/testing/selftests/kvm/dirty_log_perf_test.c > @@ -205,11 +205,6 @@ static void run_test(enum vm_guest_mode mode, void *arg) > } > } > > - /* Tell the vcpu thread to quit */ > - host_quit = true; > - for (vcpu_id = 0; vcpu_id < nr_vcpus; vcpu_id++) > - pthread_join(vcpu_threads[vcpu_id], NULL); > - > /* Disable dirty logging */ > clock_gettime(CLOCK_MONOTONIC, &start); > vm_mem_region_set_flags(vm, PERF_TEST_MEM_SLOT_INDEX, 0); > @@ -217,6 +212,11 @@ static void run_test(enum vm_guest_mode mode, void *arg) > pr_info("Disabling dirty logging time: %ld.%.9lds\n", > ts_diff.tv_sec, ts_diff.tv_nsec); > > + /* Tell the vcpu thread to quit */ > + host_quit = true; > + for (vcpu_id = 0; vcpu_id < nr_vcpus; vcpu_id++) > + pthread_join(vcpu_threads[vcpu_id], NULL); > + > avg = timespec_div(get_dirty_log_total, p->iterations); > pr_info("Get dirty log over %lu iterations took %ld.%.9lds. (Avg %ld.%.9lds/iteration)\n", > p->iterations, get_dirty_log_total.tv_sec, > Queued the two selftests patches, because why not. Paolo