From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Jean Delvare <jdelvare@suse.de>, Mani Milani <mani@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-i2c@vger.kernel.org, Heiner Kallweit <hkallweit1@gmail.com>,
Wolfram Sang <wsa@kernel.org>
Subject: Re: [PATCH] i2c: i801: Prefer async probe
Date: Fri, 30 Sep 2022 13:26:55 +0300 [thread overview]
Message-ID: <1ee061f4-8388-4a35-e14e-853482d5fc0a@linux.intel.com> (raw)
In-Reply-To: <20220929174334.44d3e6d9@endymion.delvare>
On 9/29/22 18:43, Jean Delvare wrote:
>> diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
>> index a176296f4fff..e06509edc5f3 100644
>> --- a/drivers/i2c/busses/i2c-i801.c
>> +++ b/drivers/i2c/busses/i2c-i801.c
>> @@ -1838,6 +1838,7 @@ static struct pci_driver i801_driver = {
>> .shutdown = i801_shutdown,
>> .driver = {
>> .pm = &i801_pm_ops,
>> + .probe_type = PROBE_PREFER_ASYNCHRONOUS,
>> },
>> };
>>
>
> Seems reasonable. I can't foresee any problem that would occur from
> this change, and preliminary testing on my own workstation is OK.
>
> Jarkko, Heiner, Wolfram, can you think of any reason why we should NOT
> apply this change?
>
I tested this on two systems. One with EE1004-compliant SPD EEPROM and
another with touchpad connected to RMI4 SMB bus.
Average boot time improved ~20 ms over 5 boots on the first system and
did not see any issue with the touchpad on second.
Tested-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
next prev parent reply other threads:[~2022-09-30 10:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 7:44 [PATCH] i2c: i801: Prefer async probe Mani Milani
2022-09-29 15:43 ` Jean Delvare
2022-09-29 20:59 ` Wolfram Sang
2022-09-30 8:45 ` Mani Milani
2022-09-30 10:26 ` Jarkko Nikula [this message]
2022-09-30 13:24 ` Jean Delvare
2022-10-01 22:56 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ee061f4-8388-4a35-e14e-853482d5fc0a@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=hkallweit1@gmail.com \
--cc=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@chromium.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).