From: Richard Sailer <richard_siegfried@systemli.org>
To: Baokun Li <libaokun1@huawei.com>,
davem@davemloft.net, kuba@kernel.org, dccp@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: weiyongjun1@huawei.com, yuehaibing@huawei.com,
yangjihong1@huawei.com, yukuai3@huawei.com
Subject: Re: [PATCH -next] dccp: tfrc: fix doc warnings in tfrc_equation.c
Date: Thu, 10 Jun 2021 18:44:35 +0200 [thread overview]
Message-ID: <1ef2e838-5cf9-c121-624d-3c6e5d5f1649@systemli.org> (raw)
In-Reply-To: <20210610132603.597563-1-libaokun1@huawei.com>
Just adds a correct comment. Looks fine to me.
Reviewed-by: Richard Sailer <richard_siegfried@systemli.org>
On 10/06/2021 15:26, Baokun Li wrote:
> Add description for `tfrc_invert_loss_event_rate` to fix the W=1 warnings:
>
> net/dccp/ccids/lib/tfrc_equation.c:695: warning: Function parameter or
> member 'loss_event_rate' not described in 'tfrc_invert_loss_event_rate'
>
> Signed-off-by: Baokun Li <libaokun1@huawei.com>
> ---
> net/dccp/ccids/lib/tfrc_equation.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/dccp/ccids/lib/tfrc_equation.c b/net/dccp/ccids/lib/tfrc_equation.c
> index e2a337fa9ff7..92a8c6bea316 100644
> --- a/net/dccp/ccids/lib/tfrc_equation.c
> +++ b/net/dccp/ccids/lib/tfrc_equation.c
> @@ -688,6 +688,7 @@ u32 tfrc_calc_x_reverse_lookup(u32 fvalue)
>
> /**
> * tfrc_invert_loss_event_rate - Compute p so that 10^6 corresponds to 100%
> + * @loss_event_rate: loss event rate to invert
> * When @loss_event_rate is large, there is a chance that p is truncated to 0.
> * To avoid re-entering slow-start in that case, we set p = TFRC_SMALLEST_P > 0.
> */
>
next prev parent reply other threads:[~2021-06-10 16:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 13:26 [PATCH -next] dccp: tfrc: fix doc warnings in tfrc_equation.c Baokun Li
2021-06-10 16:44 ` Richard Sailer [this message]
2021-06-10 21:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ef2e838-5cf9-c121-624d-3c6e5d5f1649@systemli.org \
--to=richard_siegfried@systemli.org \
--cc=davem@davemloft.net \
--cc=dccp@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=libaokun1@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=weiyongjun1@huawei.com \
--cc=yangjihong1@huawei.com \
--cc=yuehaibing@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).