From: "Vaittinen, Matti" <Matti.Vaittinen@fi.rohmeurope.com>
To: "yoshihiro.shimoda.uh@renesas.com"
<yoshihiro.shimoda.uh@renesas.com>,
"geert@linux-m68k.org" <geert@linux-m68k.org>
Cc: "khiem.nguyen.xt@renesas.com" <khiem.nguyen.xt@renesas.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"bgolaszewski@baylibre.com" <bgolaszewski@baylibre.com>,
linux-power <linux-power@fi.rohmeurope.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"lee.jones@linaro.org" <lee.jones@linaro.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"marek.vasut+renesas@gmail.com" <marek.vasut+renesas@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 12/12] mfd: bd9571mwv: Add support for BD9574MWF
Date: Tue, 22 Dec 2020 09:39:21 +0000 [thread overview]
Message-ID: <1f13ab9c0902ed23511b0d393e633e0d7a7abc71.camel@fi.rohmeurope.com> (raw)
In-Reply-To: <TY2PR01MB36920B85DFCE969BF8AF229CD8DF0@TY2PR01MB3692.jpnprd01.prod.outlook.com>
On Tue, 2020-12-22 at 09:23 +0000, Yoshihiro Shimoda wrote:
> Hi Geert-san,
>
> Thank you for your review!
>
> > From: Geert Uytterhoeven, Sent: Tuesday, December 22, 2020 5:53 PM
> > On Mon, Dec 21, 2020 at 3:56 AM Yoshihiro Shimoda
> > <yoshihiro.shimoda.uh@renesas.com> wrote:
> <snip>
> > > --- a/drivers/mfd/bd9571mwv.c
> > > +++ b/drivers/mfd/bd9571mwv.c
> > > @@ -200,12 +277,14 @@ static int bd9571mwv_probe(struct
> > > i2c_client *client,
> > >
> > > static const struct of_device_id bd9571mwv_of_match_table[] = {
> > > { .compatible = "rohm,bd9571mwv", },
> > > + { .compatible = "rohm,bd9574mwf", },
> > > { /* sentinel */ }
> > > };
> > > MODULE_DEVICE_TABLE(of, bd9571mwv_of_match_table);
> > >
> > > static const struct i2c_device_id bd9571mwv_id_table[] = {
> > > - { "bd9571mwv", 0 },
> > > + { "bd9571mwv", ROHM_CHIP_TYPE_BD9571 },
> > > + { "bd9574mwf", ROHM_CHIP_TYPE_BD9574 },
> >
> > Why add the chip types? These are unused, and the driver uses
> > autodetection of the chip variant anyway.
>
> I just added the chip types in the future use. As you said,
> these are unused and we should not add a future use in general.
> So, I'll remove this change.
>
> Also, I think I should remove the following patch.
>
> [PATCH v4 08/12] gpio: bd9571mwv: Add BD9574MWF support
I think this depends on whether you wish to add support for the
> "RECOV_GPOUT", "FREQSEL" and "RTC_IN",
which you mention in GPIO commit message. If you plan on adding the
support, then you need to differentiate the ICs on GPIO driver, right?
Best Regards
Matti Vaittinen
next prev parent reply other threads:[~2020-12-22 9:40 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-21 2:54 [PATCH v4 00/12] treewide: bd9571mwv: Add support for BD9574MWF Yoshihiro Shimoda
2020-12-21 2:54 ` [PATCH v4 01/12] mfd: bd9571mwv: Use devm_mfd_add_devices() Yoshihiro Shimoda
2020-12-22 8:41 ` Geert Uytterhoeven
2020-12-22 9:10 ` Vaittinen, Matti
2020-12-21 2:54 ` [PATCH v4 02/12] dt-bindings: mfd: bd9571mwv: Document BD9574MWF Yoshihiro Shimoda
2020-12-21 2:54 ` [PATCH v4 03/12] mfd: rohm-generic: Add BD9571 and BD9574 Yoshihiro Shimoda
2020-12-21 2:54 ` [PATCH v4 04/12] regulator: bd9571mwv: rid of using struct bd9571mwv Yoshihiro Shimoda
2020-12-21 2:54 ` [PATCH v4 05/12] regulator: bd9571mwv: Add BD9574MWF support Yoshihiro Shimoda
2020-12-21 2:54 ` [PATCH v4 06/12] gpio: bd9571mwv: Use the SPDX license identifier Yoshihiro Shimoda
2020-12-21 2:54 ` [PATCH v4 07/12] gpio: bd9571mwv: rid of using struct bd9571mwv Yoshihiro Shimoda
2020-12-21 2:54 ` [PATCH v4 08/12] gpio: bd9571mwv: Add BD9574MWF support Yoshihiro Shimoda
2020-12-21 2:54 ` [PATCH v4 09/12] mfd: bd9571mwv: Use the SPDX license identifier Yoshihiro Shimoda
2020-12-21 2:54 ` [PATCH v4 10/12] mfd: bd9571mwv: Use devm_regmap_add_irq_chip() Yoshihiro Shimoda
2020-12-22 8:49 ` Geert Uytterhoeven
2020-12-22 9:15 ` Vaittinen, Matti
2020-12-22 9:25 ` Yoshihiro Shimoda
2020-12-22 9:39 ` Vaittinen, Matti
2020-12-22 11:15 ` Yoshihiro Shimoda
2020-12-21 2:54 ` [PATCH v4 11/12] mfd: bd9571mwv: Make the driver more generic Yoshihiro Shimoda
2020-12-21 2:54 ` [PATCH v4 12/12] mfd: bd9571mwv: Add support for BD9574MWF Yoshihiro Shimoda
2020-12-22 8:52 ` Geert Uytterhoeven
2020-12-22 9:23 ` Yoshihiro Shimoda
2020-12-22 9:32 ` Geert Uytterhoeven
2020-12-22 10:49 ` Yoshihiro Shimoda
2020-12-22 9:39 ` Vaittinen, Matti [this message]
2020-12-22 10:51 ` Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f13ab9c0902ed23511b0d393e633e0d7a7abc71.camel@fi.rohmeurope.com \
--to=matti.vaittinen@fi.rohmeurope.com \
--cc=bgolaszewski@baylibre.com \
--cc=broonie@kernel.org \
--cc=geert@linux-m68k.org \
--cc=khiem.nguyen.xt@renesas.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-power@fi.rohmeurope.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).