From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C445C4332B for ; Wed, 10 Mar 2021 14:28:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 66AA464FBC for ; Wed, 10 Mar 2021 14:28:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233118AbhCJO20 (ORCPT ); Wed, 10 Mar 2021 09:28:26 -0500 Received: from out28-194.mail.aliyun.com ([115.124.28.194]:50209 "EHLO out28-194.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233128AbhCJO2F (ORCPT ); Wed, 10 Mar 2021 09:28:05 -0500 X-Alimail-AntiSpam: AC=CONTINUE;BC=0.0794919|-1;CH=green;DM=|CONTINUE|false|;DS=CONTINUE|ham_social|0.00732443-0.00430509-0.98837;FP=0|0|0|0|0|-1|-1|-1;HT=ay29a033018047204;MF=zhouyanjie@wanyeetech.com;NM=1;PH=DS;RN=13;RT=13;SR=0;TI=SMTPD_---.Jj139MB_1615386481; Received: from 192.168.10.152(mailfrom:zhouyanjie@wanyeetech.com fp:SMTPD_---.Jj139MB_1615386481) by smtp.aliyun-inc.com(10.147.42.253); Wed, 10 Mar 2021 22:28:02 +0800 Subject: Re: [PATCH 1/3] pinctrl: Ingenic: Fix bug and reformat the code. To: Paul Cercueil , Andy Shevchenko Cc: Linus Walleij , Rob Herring , linux-mips@vger.kernel.org, GPIO SUBSYSTEM , Linux Kernel Mailing List , devicetree , "H. Nikolaus Schaller" , paul@boddie.org.uk, dongsheng.qiu@ingenic.com, aric.pzqi@ingenic.com, sernia.zhou@foxmail.com References: <1615308057-88387-1-git-send-email-zhouyanjie@wanyeetech.com> <1615308057-88387-2-git-send-email-zhouyanjie@wanyeetech.com> From: Zhou Yanjie Message-ID: <1f213c50-cc8b-b290-aa71-e5d4be47f1fe@wanyeetech.com> Date: Wed, 10 Mar 2021 22:28:01 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Paul, On 2021/3/10 下午10:19, Paul Cercueil wrote: > > > Le mer. 10 mars 2021 à 16:03, Andy Shevchenko > a écrit : >> On Tue, Mar 9, 2021 at 6:42 PM 周琰杰 (Zhou Yanjie) >> wrote: >>> >>>  1.Add tabs before values to align the code in the macro definition >>> section. >>>  2.Fix bugs related to the MAC of JZ4770, add missing pins to the >>> MII group. >>>  3.Adjust the sequence of X1830's SSI related codes to make it >>> consistent >>>    with other Ingenic SoCs. >>>  4.Fix bug in "ingenic_pinconf_get()", so that it can read the >>> configuration >>>    of X1830 SoC correctly. >>> >> >> Split to 4 patches then. >> It's quite hard for everybody to handle regression fixes like this. > > Agreed. And the fixes should have a Fixes: tag. > Sure. > -Paul >