linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tiezhu Yang <yangtiezhu@loongson.cn>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
	linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
	Xuefeng Li <lixuefeng@loongson.cn>
Subject: Re: [PATCH] MIPS: DTS: Only build subdir of current platform
Date: Thu, 28 May 2020 09:24:37 +0800	[thread overview]
Message-ID: <1f29c8f8-730c-d8d4-c8ed-cdf9f02e981f@loongson.cn> (raw)
In-Reply-To: <20200527231055.GA141265@roeck-us.net>

On 05/28/2020 07:10 AM, Guenter Roeck wrote:
> On Thu, May 21, 2020 at 10:15:06AM +0800, Tiezhu Yang wrote:
>> Add config check in Makefile to only build the subdir of current platform.
>>
>> E.g. without this patch:
>>
>>    AR      arch/mips/built-in.a
>>    AR      arch/mips/boot/dts/brcm/built-in.a
>>    AR      arch/mips/boot/dts/cavium-octeon/built-in.a
>>    AR      arch/mips/boot/dts/img/built-in.a
>>    AR      arch/mips/boot/dts/ingenic/built-in.a
>>    AR      arch/mips/boot/dts/lantiq/built-in.a
>>    DTC     arch/mips/boot/dts/loongson/loongson3_4core_rs780e.dtb
>>    DTB     arch/mips/boot/dts/loongson/loongson3_4core_rs780e.dtb.S
>>    AS      arch/mips/boot/dts/loongson/loongson3_4core_rs780e.dtb.o
>>    DTC     arch/mips/boot/dts/loongson/loongson3_8core_rs780e.dtb
>>    DTB     arch/mips/boot/dts/loongson/loongson3_8core_rs780e.dtb.S
>>    AS      arch/mips/boot/dts/loongson/loongson3_8core_rs780e.dtb.o
>>    AR      arch/mips/boot/dts/loongson/built-in.a
>>    AR      arch/mips/boot/dts/mscc/built-in.a
>>    AR      arch/mips/boot/dts/mti/built-in.a
>>    AR      arch/mips/boot/dts/netlogic/built-in.a
>>    AR      arch/mips/boot/dts/ni/built-in.a
>>    AR      arch/mips/boot/dts/pic32/built-in.a
>>    AR      arch/mips/boot/dts/qca/built-in.a
>>    AR      arch/mips/boot/dts/ralink/built-in.a
>>    AR      arch/mips/boot/dts/xilfpga/built-in.a
>>    AR      arch/mips/boot/dts/built-in.a
>>
>> With this patch:
>>
>>    AR      arch/mips/built-in.a
>>    DTC     arch/mips/boot/dts/loongson/loongson3_4core_rs780e.dtb
>>    DTB     arch/mips/boot/dts/loongson/loongson3_4core_rs780e.dtb.S
>>    AS      arch/mips/boot/dts/loongson/loongson3_4core_rs780e.dtb.o
>>    DTC     arch/mips/boot/dts/loongson/loongson3_8core_rs780e.dtb
>>    DTB     arch/mips/boot/dts/loongson/loongson3_8core_rs780e.dtb.S
>>    AS      arch/mips/boot/dts/loongson/loongson3_8core_rs780e.dtb.o
>>    AR      arch/mips/boot/dts/loongson/built-in.a
>>    AR      arch/mips/boot/dts/built-in.a
>>
>> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> With this patch applied, boston.dtb is no longer built with
> 64r6el_defconfig, even though 64r6el_defconfig enables
> CONFIG_FIT_IMAGE_FDT_BOSTON=y. This is because the img
> subdirectory is now only included if CONFIG_MACH_PISTACHIO=y,
> but that is not the case with 64r6el_defconfig.

Thanks for your report, sorry for this issue.

I received the build error report yesterday from
kbuild test robot <lkp@intel.com>, I will fix it.

>
> Please revisit.
>
> Guenter
>
>> ---
>>   arch/mips/boot/dts/Makefile | 28 ++++++++++++++--------------
>>   1 file changed, 14 insertions(+), 14 deletions(-)
>>
>> diff --git a/arch/mips/boot/dts/Makefile b/arch/mips/boot/dts/Makefile
>> index d429a69..dce32d1 100644
>> --- a/arch/mips/boot/dts/Makefile
>> +++ b/arch/mips/boot/dts/Makefile
>> @@ -1,17 +1,17 @@
>>   # SPDX-License-Identifier: GPL-2.0
>> -subdir-y	+= brcm
>> -subdir-y	+= cavium-octeon
>> -subdir-y	+= img
>> -subdir-y	+= ingenic
>> -subdir-y	+= lantiq
>> -subdir-y	+= loongson
>> -subdir-y	+= mscc
>> -subdir-y	+= mti
>> -subdir-y	+= netlogic
>> -subdir-y	+= ni
>> -subdir-y	+= pic32
>> -subdir-y	+= qca
>> -subdir-y	+= ralink
>> -subdir-y	+= xilfpga
>> +subdir-$(CONFIG_BMIPS_GENERIC)		+= brcm
>> +subdir-$(CONFIG_CAVIUM_OCTEON_SOC)	+= cavium-octeon
>> +subdir-$(CONFIG_MACH_PISTACHIO)		+= img
>> +subdir-$(CONFIG_MACH_INGENIC)		+= ingenic
>> +subdir-$(CONFIG_LANTIQ)			+= lantiq
>> +subdir-$(CONFIG_MACH_LOONGSON64)	+= loongson
>> +subdir-$(CONFIG_MSCC_OCELOT)		+= mscc
>> +subdir-$(CONFIG_MIPS_MALTA)		+= mti
>> +subdir-$(CONFIG_NLM_XLP_BOARD)		+= netlogic
>> +subdir-$(CONFIG_FIT_IMAGE_FDT_NI169445)	+= ni
>> +subdir-$(CONFIG_MACH_PIC32)		+= pic32
>> +subdir-$(CONFIG_ATH79)			+= qca
>> +subdir-$(CONFIG_RALINK)			+= ralink
>> +subdir-$(CONFIG_FIT_IMAGE_FDT_XILFPGA)	+= xilfpga
>>   
>>   obj-$(CONFIG_BUILTIN_DTB)	:= $(addsuffix /, $(subdir-y))
>> -- 
>> 2.1.0
>>


      reply	other threads:[~2020-05-28  1:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-21  2:15 [PATCH] MIPS: DTS: Only build subdir of current platform Tiezhu Yang
2020-05-24  9:28 ` Thomas Bogendoerfer
2020-05-27 23:10 ` Guenter Roeck
2020-05-28  1:24   ` Tiezhu Yang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1f29c8f8-730c-d8d4-c8ed-cdf9f02e981f@loongson.cn \
    --to=yangtiezhu@loongson.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=lixuefeng@loongson.cn \
    --cc=tsbogend@alpha.franken.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).