From: Anshuman Khandual <anshuman.khandual@arm.com>
To: mawupeng <mawupeng1@huawei.com>,
david@redhat.com, corbet@lwn.net, will@kernel.org,
ardb@kernel.org, catalin.marinas@arm.com
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
dvhart@infradead.org, andy@infradead.org, rppt@kernel.org,
akpm@linux-foundation.org, paul.walmsley@sifive.com,
palmer@dabbelt.com, aou@eecs.berkeley.edu, paulmck@kernel.org,
keescook@chromium.org, songmuchun@bytedance.com,
rdunlap@infradead.org, damien.lemoal@opensource.wdc.com,
swboyd@chromium.org, wei.liu@kernel.org, robin.murphy@arm.com,
thunder.leizhen@huawei.com, wangkefeng.wang@huawei.com,
gpiccoli@igalia.com, chenhuacai@kernel.org, geert@linux-m68k.org,
vijayb@linux.microsoft.com, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-efi@vger.kernel.org,
platform-driver-x86@vger.kernel.org, linux-mm@kvack.org,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH v3 4/6] mm: Demote warning message in vmemmap_verify() to debug level
Date: Wed, 8 Jun 2022 15:30:26 +0530 [thread overview]
Message-ID: <1f2a76d5-7c4e-46bc-ce66-20a962eac73c@arm.com> (raw)
In-Reply-To: <a820f287-e879-6183-a917-6a577b6160ab@huawei.com>
On 6/8/22 06:56, mawupeng wrote:
>
>
> 在 2022/6/7 20:25, David Hildenbrand 写道:
>> On 07.06.22 11:38, Wupeng Ma wrote:
>>> From: Ma Wupeng <mawupeng1@huawei.com>
>>>
>>> For a system only have limited mirrored memory or some numa node without
>>> mirrored memory, the per node vmemmap page_structs prefer to allocate
>>> memory from mirrored region, which will lead to vmemmap_verify() in
>>> vmemmap_populate_basepages() report lots of warning message.
>>>
>>> This patch demote the "potential offnode page_structs" warning messages
>>> to debug level to avoid a very long print during bootup.
>>>
>>> Signed-off-by: Ma Wupeng <mawupeng1@huawei.com>
>>> ---
>>> mm/sparse-vmemmap.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/mm/sparse-vmemmap.c b/mm/sparse-vmemmap.c
>>> index f4fa61dbbee3..78debdb89eb1 100644
>>> --- a/mm/sparse-vmemmap.c
>>> +++ b/mm/sparse-vmemmap.c
>>> @@ -528,7 +528,7 @@ void __meminit vmemmap_verify(pte_t *pte, int node,
>>> int actual_node = early_pfn_to_nid(pfn);
>>> if (node_distance(actual_node, node) > LOCAL_DISTANCE)
>>> - pr_warn("[%lx-%lx] potential offnode page_structs\n",
>>> + pr_debug("[%lx-%lx] potential offnode page_structs\n",
>>> start, end - 1);
>>> }
>>>
>>
>> This will possibly hide it in environments where this might indeed
>> indicate performance issues.
>>
>> What about a pr_warn_once()?
>>
>
> Sure.
>
> This will works. We can certainly use a pr_warn_once().
Why not pr_warn_ratelimited() like in the previous patch ?
next prev parent reply other threads:[~2022-06-08 10:15 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 9:37 [PATCH v3 0/6] introduce mirrored memory support for arm64 Wupeng Ma
2022-06-07 9:38 ` [PATCH v3 1/6] efi: Make efi_find_mirror() public Wupeng Ma
2022-06-10 9:22 ` Kefeng Wang
2022-06-07 9:38 ` [PATCH v3 2/6] arm64/mirror: arm64 enabling - find mirrored memory ranges Wupeng Ma
2022-06-10 9:27 ` Kefeng Wang
2022-06-10 9:34 ` Ard Biesheuvel
2022-06-10 10:24 ` Kefeng Wang
2022-06-10 11:17 ` Ard Biesheuvel
2022-06-07 9:38 ` [PATCH v3 3/6] mm: Ratelimited mirrored memory related warning messages Wupeng Ma
2022-06-07 12:24 ` David Hildenbrand
2022-06-08 9:44 ` Mike Rapoport
2022-06-08 10:02 ` Anshuman Khandual
2022-06-10 9:29 ` Kefeng Wang
2022-06-07 9:38 ` [PATCH v3 4/6] mm: Demote warning message in vmemmap_verify() to debug level Wupeng Ma
2022-06-07 12:25 ` David Hildenbrand
2022-06-08 1:26 ` mawupeng
2022-06-08 10:00 ` Anshuman Khandual [this message]
2022-06-09 8:13 ` mawupeng
2022-06-10 9:35 ` Kefeng Wang
2022-06-07 9:38 ` [PATCH v3 5/6] mm: Add mirror flag back on initrd memory Wupeng Ma
2022-06-07 12:21 ` David Hildenbrand
2022-06-07 14:49 ` Ard Biesheuvel
2022-06-08 7:27 ` mawupeng
2022-06-08 10:02 ` Mike Rapoport
2022-06-08 10:08 ` David Hildenbrand
2022-06-08 10:12 ` Ard Biesheuvel
2022-06-09 8:15 ` mawupeng
2022-06-10 11:06 ` Ard Biesheuvel
2022-06-07 9:38 ` [PATCH v3 6/6] efi: Disable mirror feature if kernelcore is not specified Wupeng Ma
2022-06-10 11:20 ` Ard Biesheuvel
2022-06-10 12:15 ` Kefeng Wang
2022-06-10 11:23 ` [PATCH v3 0/6] introduce mirrored memory support for arm64 Ard Biesheuvel
2022-06-10 11:24 ` Ard Biesheuvel
2022-06-11 9:56 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f2a76d5-7c4e-46bc-ce66-20a962eac73c@arm.com \
--to=anshuman.khandual@arm.com \
--cc=akpm@linux-foundation.org \
--cc=andy@infradead.org \
--cc=aou@eecs.berkeley.edu \
--cc=ardb@kernel.org \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=chenhuacai@kernel.org \
--cc=corbet@lwn.net \
--cc=damien.lemoal@opensource.wdc.com \
--cc=dave.hansen@linux.intel.com \
--cc=david@redhat.com \
--cc=dvhart@infradead.org \
--cc=geert@linux-m68k.org \
--cc=gpiccoli@igalia.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mawupeng1@huawei.com \
--cc=mingo@redhat.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=paulmck@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=robin.murphy@arm.com \
--cc=rppt@kernel.org \
--cc=songmuchun@bytedance.com \
--cc=swboyd@chromium.org \
--cc=tglx@linutronix.de \
--cc=thunder.leizhen@huawei.com \
--cc=vijayb@linux.microsoft.com \
--cc=wangkefeng.wang@huawei.com \
--cc=wei.liu@kernel.org \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).