From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47933C432BE for ; Thu, 2 Sep 2021 09:22:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 27F2461058 for ; Thu, 2 Sep 2021 09:22:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245385AbhIBJW5 (ORCPT ); Thu, 2 Sep 2021 05:22:57 -0400 Received: from out30-132.freemail.mail.aliyun.com ([115.124.30.132]:33287 "EHLO out30-132.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245139AbhIBJWx (ORCPT ); Thu, 2 Sep 2021 05:22:53 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R121e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04420;MF=laijs@linux.alibaba.com;NM=1;PH=DS;RN=16;SR=0;TI=SMTPD_---0Un.S-zH_1630574511; Received: from C02XQCBJJG5H.local(mailfrom:laijs@linux.alibaba.com fp:SMTPD_---0Un.S-zH_1630574511) by smtp.aliyun-inc.com(127.0.0.1); Thu, 02 Sep 2021 17:21:51 +0800 Subject: Re: [PATCH 02/24] x86/traps: Move arch/x86/kernel/traps.c to arch/x86/entry/ To: Joerg Roedel , Lai Jiangshan Cc: linux-kernel@vger.kernel.org, Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , "Peter Zijlstra (Intel)" , Daniel Bristot de Oliveira , Brijesh Singh , Andy Shevchenko , Arvind Sankar , Chester Lin , Juergen Gross References: <20210831175025.27570-1-jiangshanlai@gmail.com> <20210831175025.27570-3-jiangshanlai@gmail.com> From: Lai Jiangshan Message-ID: <1f327579-e62a-df65-0763-e88243829db3@linux.alibaba.com> Date: Thu, 2 Sep 2021 17:21:51 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/9/2 16:09, Joerg Roedel wrote: > On Wed, Sep 01, 2021 at 01:50:03AM +0800, Lai Jiangshan wrote: >> arch/x86/entry/Makefile | 5 ++++- >> arch/x86/{kernel => entry}/traps.c | 0 >> arch/x86/kernel/Makefile | 5 +---- >> 3 files changed, 5 insertions(+), 5 deletions(-) >> rename arch/x86/{kernel => entry}/traps.c (100%) > > From looking over the patch-set I didn't spot the reason for putting the > entry C code into traps.c. Can you explain that please? Otherwise I'd > prefer to create a new file, like arch/x86/entry/entry64.c. I agree, and I think Peter is handling it. Thanks Lai