From: Igor Russkikh <irusskikh@marvell.com>
To: Manuel Ullmann <labre@posteo.de>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
regressions@lists.linux.dev, davem@davemloft.net,
kuba@kernel.org, pabeni@redhat.com,
"Jordan Leppert" <jordanleppert@protonmail.com>,
"Holger Hoffstätte" <holger@applied-asynchrony.com>,
koo5 <kolman.jindrich@gmail.com>,
"Dmitry Bezrukov" <dbezrukov@marvell.com>
Subject: Re: [EXT] [PATCH] net: atlantic: always deep reset on pm op, fixing null deref regression
Date: Thu, 5 May 2022 09:04:48 +0200 [thread overview]
Message-ID: <1f4b595a-1553-f015-c7a0-6d3075bdbcda@marvell.com> (raw)
In-Reply-To: <87czgt2bsb.fsf@posteo.de>
> The impact of this regression is the same for resume that I saw on
> thaw: the kernel hangs and nothing except SysRq rebooting can be done.
>
> The null deref occurs at the same position as on thaw.
> BUG: kernel NULL pointer dereference
> RIP: aq_ring_rx_fill+0xcf/0x210 [atlantic]
>
> Fixes regression in cbe6c3a8f8f4 ("net: atlantic: invert deep par in
> pm functions, preventing null derefs"), where I disabled deep pm
> resets in suspend and resume, trying to make sense of the
> atl_resume_common deep parameter in the first place.
>
> It turns out, that atlantic always has to deep reset on pm operations
> and the parameter is useless. Even though I expected that and tested
> resume, I screwed up by kexec-rebooting into an unpatched kernel, thus
> missing the breakage.
>
> This fixup obsoletes the deep parameter of atl_resume_common, but I
> leave the cleanup for the maintainers to post to mainline.
>
> PS: I'm very sorry for this regression.
Hi Manuel,
Unfortunately I've missed to review and comment on previous patch - it was too quickly accepted.
I'm still in doubt on your fixes, even after rereading the original problem.
Is it possible for you to test this with all the possible combinations?
suspend/resume with device up/down,
hibernate/restore with device up/down?
I'll try to do the same on our side, but we don't have much resources for that now unfortunately..
> Fixes: cbe6c3a8f8f4315b96e46e1a1c70393c06d95a4c
That tag format is incorrect I think..
Igor
next prev parent reply other threads:[~2022-05-05 7:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 22:06 [PATCH] net: atlantic: always deep reset on pm op, fixing null deref regression Manuel Ullmann
2022-05-04 22:24 ` Holger Hoffstätte
2022-05-05 7:04 ` Igor Russkikh [this message]
2022-05-05 10:24 ` [EXT] " Jordan Leppert
2022-05-05 17:39 ` Manuel Ullmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f4b595a-1553-f015-c7a0-6d3075bdbcda@marvell.com \
--to=irusskikh@marvell.com \
--cc=davem@davemloft.net \
--cc=dbezrukov@marvell.com \
--cc=holger@applied-asynchrony.com \
--cc=jordanleppert@protonmail.com \
--cc=kolman.jindrich@gmail.com \
--cc=kuba@kernel.org \
--cc=labre@posteo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=regressions@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).