From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752388AbdF2Knp (ORCPT ); Thu, 29 Jun 2017 06:43:45 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:36772 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751703AbdF2Knm (ORCPT ); Thu, 29 Jun 2017 06:43:42 -0400 Subject: Re: [PATCH 0/2] staging: ccree: Fix coding style and remove warnings To: Gilad Ben-Yossef Cc: Greg Kroah-Hartman , linux-crypto@vger.kernel.org, driverdev-devel@linuxdriverproject.org, devel@driverdev.osuosl.org, Linux kernel mailing list , sunil.m@techveda.org References: <1498642633-3260-1-git-send-email-karthik@techveda.org> From: karthik Message-ID: <1f681a83-4413-8c9d-ab75-c223b6c8b55b@techveda.org> Date: Thu, 29 Jun 2017 16:13:38 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 28 June 2017 03:15 PM, Gilad Ben-Yossef wrote: > Thank you Karthik, > > On Wed, Jun 28, 2017 at 12:37 PM, wrote: >> From: Karthik Tummala >> >> This patch series fixes coding style and removes the following >> checkpatch.pl warnings: >> >> Prefer using '"%s...", __func__' to using the function's name, >> in a string. > > This one is good. >> >> Braces {} are not necessary for single statement blocks. > > I have already sent a patch addressing this and some other things > yesterday/ > >> >> Rebased on top of next-20170627. >> Patches were tested and built on next-20170627 > > Can you please check patch 1 still applies after yesterdays patch series? Hi, I have applied your patch series and then tried to apply patch 1 and it failed. Should I wait until the patch series gets accepted and then continue my work on the new linux-next release ? or is there any other option ? > >> >> Karthik Tummala (2): >> staging: ccree: Use __func__ instead of function name >> staging: ccree: Remove braces {} for single statement blocks >> >> drivers/staging/ccree/ssi_aead.c | 48 ++++++++++++++++------------------------ >> 1 file changed, 19 insertions(+), 29 deletions(-) >> >> -- >> 1.9.1 >> > > Thanks, > Gilad > Thanks karthik