From: Liran Alon <liran.alon@oracle.com>
To: <kernellwp@gmail.com>
Cc: <rkrcmar@redhat.com>, <pbonzini@redhat.com>,
<linux-kernel@vger.kernel.org>, <kvm@vger.kernel.org>
Subject: Re: [PATCH] KVM: X86: Allow userspace to define the microcode version
Date: Mon, 26 Feb 2018 01:26:19 -0800 (PST) [thread overview]
Message-ID: <1f6d0e8e-6d76-4262-9e8b-f8b1f23d8248@default> (raw)
----- kernellwp@gmail.com wrote:
> From: Wanpeng Li <wanpengli@tencent.com>
>
> Linux (among the others) has checks to make sure that certain features
>
> aren't enabled on a certain family/model/stepping if the microcode
> version
> isn't greater than or equal to a known good version.
>
> By exposing the real microcode version, we're preventing buggy guests
> that
> don't check that they are running virtualized (i.e., they should trust
> the
> hypervisor) from disabling features that are effectively not buggy.
>
> Suggested-by: Filippo Sironi <sironi@amazon.de>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Radim Krčmář <rkrcmar@redhat.com>
> Signed-off-by: Wanpeng Li <wanpengli@tencent.com>
> ---
> arch/x86/include/asm/kvm_host.h | 1 +
> arch/x86/kvm/x86.c | 8 ++++++--
> 2 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/include/asm/kvm_host.h
> b/arch/x86/include/asm/kvm_host.h
> index 938d453..6e13f2f 100644
> --- a/arch/x86/include/asm/kvm_host.h
> +++ b/arch/x86/include/asm/kvm_host.h
> @@ -507,6 +507,7 @@ struct kvm_vcpu_arch {
> u64 smi_count;
> bool tpr_access_reporting;
> u64 ia32_xss;
> + u32 microcode_version;
>
> /*
> * Paging state of the vcpu
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 1a3ed81..cc51c61 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -2247,7 +2247,6 @@ int kvm_set_msr_common(struct kvm_vcpu *vcpu,
> struct msr_data *msr_info)
>
> switch (msr) {
> case MSR_AMD64_NB_CFG:
> - case MSR_IA32_UCODE_REV:
> case MSR_IA32_UCODE_WRITE:
> case MSR_VM_HSAVE_PA:
> case MSR_AMD64_PATCH_LOADER:
> @@ -2255,6 +2254,10 @@ int kvm_set_msr_common(struct kvm_vcpu *vcpu,
> struct msr_data *msr_info)
> case MSR_AMD64_DC_CFG:
> break;
>
> + case MSR_IA32_UCODE_REV:
> + if (msr_info->host_initiated)
> + vcpu->arch.microcode_version = data >> 32;
> + break;
> case MSR_EFER:
> return set_efer(vcpu, data);
> case MSR_K7_HWCR:
> @@ -2550,7 +2553,7 @@ int kvm_get_msr_common(struct kvm_vcpu *vcpu,
> struct msr_data *msr_info)
> msr_info->data = 0;
> break;
> case MSR_IA32_UCODE_REV:
> - msr_info->data = 0x100000000ULL;
> + msr_info->data = (u64)vcpu->arch.microcode_version << 32;
> break;
> case MSR_MTRRcap:
> case 0x200 ... 0x2ff:
> @@ -8232,6 +8235,7 @@ void kvm_vcpu_reset(struct kvm_vcpu *vcpu, bool
> init_event)
> vcpu->arch.regs_dirty = ~0;
>
> vcpu->arch.ia32_xss = 0;
> + vcpu->arch.microcode_version = 0x1;
>
> kvm_x86_ops->vcpu_reset(vcpu, init_event);
> }
> --
> 2.7.4
I think you need to add MSR_IA32_UCODE_REV to emulated_msrs[]
to allow for proper live-migration of this MSR value.
The rest seems fine to me. :)
Regards,
-Liran
next reply other threads:[~2018-02-26 9:26 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-26 9:26 Liran Alon [this message]
2018-02-26 10:08 ` [PATCH] KVM: X86: Allow userspace to define the microcode version Wanpeng Li
-- strict thread matches above, loose matches on Subject: below --
2018-02-26 7:23 Wanpeng Li
2018-02-26 9:41 ` Borislav Petkov
2018-02-26 10:06 ` Wanpeng Li
2018-02-26 10:49 ` Borislav Petkov
2018-02-26 11:02 ` Wanpeng Li
2018-02-26 11:16 ` Borislav Petkov
2018-02-26 11:25 ` Wanpeng Li
2018-02-26 11:30 ` Borislav Petkov
2018-02-26 11:37 ` Wanpeng Li
2018-02-26 11:44 ` Borislav Petkov
2018-02-26 11:52 ` Wanpeng Li
2018-02-26 11:54 ` Paolo Bonzini
2018-02-26 12:15 ` Borislav Petkov
2018-02-26 12:16 ` Paolo Bonzini
2018-02-26 12:18 ` Paolo Bonzini
2018-02-26 12:22 ` Borislav Petkov
2018-02-26 12:41 ` Paolo Bonzini
2018-02-26 13:05 ` Borislav Petkov
2018-02-26 14:39 ` Konrad Rzeszutek Wilk
2018-02-26 14:46 ` Paolo Bonzini
2018-02-26 19:37 ` Borislav Petkov
2018-02-26 20:51 ` Konrad Rzeszutek Wilk
2018-02-26 21:30 ` Konrad Rzeszutek Wilk
2018-02-27 8:33 ` Paolo Bonzini
2018-04-17 10:40 ` Wanpeng Li
2018-04-17 20:24 ` Eduardo Habkost
2018-04-18 3:24 ` Wanpeng Li
2018-04-18 9:03 ` Eduardo Habkost
2018-04-18 10:36 ` Paolo Bonzini
2018-04-23 12:58 ` Borislav Petkov
2018-04-23 13:08 ` Eduardo Habkost
2018-04-23 13:23 ` Borislav Petkov
2018-04-23 16:03 ` Paolo Bonzini
2018-04-24 2:59 ` Wanpeng Li
2018-04-24 3:14 ` Konrad Rzeszutek Wilk
2018-04-24 5:09 ` Paolo Bonzini
2018-04-24 13:44 ` Konrad Rzeszutek Wilk
2018-04-24 2:56 ` Wanpeng Li
2018-02-26 11:47 ` Paolo Bonzini
2018-02-26 12:20 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f6d0e8e-6d76-4262-9e8b-f8b1f23d8248@default \
--to=liran.alon@oracle.com \
--cc=kernellwp@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).