From: Perry Yuan <perry979106@gmail.com>
To: "Hans de Goede" <hdegoede@redhat.com>,
"Barnabás Pőcze" <pobrn@protonmail.com>,
"Perry Yuan" <Perry.Yuan@dell.com>
Cc: "mgross@linux.intel.com" <mgross@linux.intel.com>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Limonciello Mario <Mario.Limonciello@dell.com>
Subject: Re: [PATCH v2 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy
Date: Fri, 15 Jan 2021 15:44:14 +0800 [thread overview]
Message-ID: <1f72244c-4510-f945-6997-baa3fcdf9d7b@gmail.com> (raw)
In-Reply-To: <ce598a92-73ef-e9a6-d772-59f5da3d251e@redhat.com>
On 2021/1/13 2:37, Hans de Goede wrote:
> Hi,
>
> I know there already is a v3 out and I will try to get around to reviewing
> that soon, still 1 remark about the discussion surrounding v2:
>
> On 1/11/21 2:42 PM, Perry Yuan wrote:
>
> <snip>
>
>>>> *The flow is like this:
>>>> 1) User presses key. HW does stuff with this key (timeout is started)
>>>> 2) Event is emitted from FW
>>>> 3) Event received by dell-privacy
>>>> 4) KEY_MICMUTE emitted from dell-privacy
>>>> 5) Userland picks up key and modifies kcontrol for SW mute
>>>> 6) Codec kernel driver catches and calls ledtrig_audio_set, like this:
>>>> ledtrig_audio_set(LED_AUDIO_MICMUTE,
>>>> rt715->micmute_led ? LED_ON :LED_OFF);
>>>> 7) If "LED" is set to on dell-privacy notifies ec,
>>>> and timeout is cancelled,HW mic mute activated.
>>>>
>>> Please proofread the commit message again, and pay attention to capitalization
>>> and spacing.
>> I want to reformat it and move the commit info to cover letter.
> Please also put a copy of this as a comment in either the wmi or the
> acpi driver (with a comment pointing to the comment in the other) this is
> important info to have for someone reading the code and trying to understand
> how this all fits together.
>
> Regards,
>
> Hans
Hi Hans:
Agreed.
I will add this to the driver comments and explain how the acpi/wmi
driver associated.
next prev parent reply other threads:[~2021-01-15 7:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-28 13:28 [PATCH v2 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy Perry Yuan
2020-12-28 20:26 ` Barnabás Pőcze
[not found] ` <7def1cdc-e275-9ae6-4941-55517359bb1e@gmail.com>
2021-01-11 16:07 ` Barnabás Pőcze
2021-01-12 17:26 ` Perry Yuan
2021-01-12 18:37 ` Hans de Goede
2021-01-15 7:44 ` Perry Yuan [this message]
2021-02-16 7:24 ` Perry Yuan
2021-03-04 10:49 ` Hans de Goede
2021-01-06 23:43 ` Hans de Goede
2021-01-07 16:03 ` Barnabás Pőcze
2021-01-08 17:04 ` Yuan, Perry
2021-01-08 17:06 ` Limonciello, Mario
2021-01-08 17:34 ` Yuan, Perry
-- strict thread matches above, loose matches on Subject: below --
2020-12-28 13:08 Perry Yuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f72244c-4510-f945-6997-baa3fcdf9d7b@gmail.com \
--to=perry979106@gmail.com \
--cc=Mario.Limonciello@dell.com \
--cc=Perry.Yuan@dell.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=pobrn@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).