From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Quentin Perret <quentin.perret@arm.com>
Cc: edubezval@gmail.com, javi.merino@kernel.org,
viresh.kumar@linaro.org, amit.kachhap@gmail.com,
rjw@rjwysocki.net, will.deacon@arm.com, catalin.marinas@arm.com,
dietmar.eggemann@arm.com, ionela.voinescu@arm.com,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Zhang Rui <rui.zhang@intel.com>
Subject: Re: [PATCH 1/3] arm64: defconfig: Enable CONFIG_ENERGY_MODEL
Date: Thu, 28 Mar 2019 20:51:12 +0100 [thread overview]
Message-ID: <1f99acdf-3f9a-5419-b1b5-1bcb9b36dbb6@linaro.org> (raw)
In-Reply-To: <20190328174233.jthsdzxrzmzpjnqd@queper01-lin>
On 28/03/2019 18:42, Quentin Perret wrote:
> Hi Daniel,
>
> On Thursday 28 Mar 2019 at 18:27:49 (+0100), Daniel Lezcano wrote:
>> On 28/03/2019 11:22, Quentin Perret wrote:
>>>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
>>>> index 2d9c39033c1a..3c09bdaaefd3 100644
>>>> --- a/arch/arm64/configs/defconfig
>>>> +++ b/arch/arm64/configs/defconfig
>>>> @@ -97,6 +97,7 @@ CONFIG_XEN=y
>>>> CONFIG_COMPAT=y
>>>> CONFIG_HIBERNATION=y
>>>> CONFIG_WQ_POWER_EFFICIENT_DEFAULT=y
>>>> +CONFIG_ENERGY_MODEL=n
>>>
>>> Hmm, sorry I turned this to '=n' for testing and forgot to update the
>>> patch. This obviously should be '=y' ...
>>
>> I did a test without the ENERGY_MODEL config option set, dhrystone and
>> the power_allocator policy on the hikey. The board did not mitigate well
>> and ended up rebooting.
>
> OK ... And is the same thing happening if you just run mainline w/o the
> dynamic-power-coefficient binding set for example ? The result _should_
> be the same.
Right, it is the same.
> If not, then perhaps I missed something. I'll try to
> reproduce on my end. Just to be sure, when you say hikey, you mean
> hikey960 ? Or 620 ? In any case, thanks for testing :-)
hikey620
>> May be the cpu cooling Kconfig option should add
>> a SELECT or a DEPENDS on ENERGY_MODEL ?
>
> Right, I've been wondering the same thing. I'm not a big fan of 'select'
> because enabling ENERGY_MODEL automatically for the thermal stuff will
> also happen to enable other things (EAS) without the user knowing. So
> I'd rather keep the ENERGY_MODEL option explicit.
>
> But perhaps having THERMAL_GOV_POWER_ALLOCATOR 'depend on ENERGY_MODEL'
> could work. It's just that there is no _strong_ dependency, the IPA code
> isn't supposed to crash even if there is no EM ...
Given if the ENERGY_MODEL is not set there is a regression we should add
the dependency IMO.
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2019-03-28 19:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-28 10:13 [PATCH 0/3] cpu_cooling: Make IPA use PM_EM Quentin Perret
2019-03-28 10:13 ` [PATCH 1/3] arm64: defconfig: Enable CONFIG_ENERGY_MODEL Quentin Perret
2019-03-28 10:22 ` Quentin Perret
2019-03-28 17:27 ` Daniel Lezcano
2019-03-28 17:42 ` Quentin Perret
2019-03-28 19:51 ` Daniel Lezcano [this message]
2019-03-29 9:03 ` Quentin Perret
2019-03-28 10:13 ` [PATCH 2/3] PM / EM: Expose perf domain struct Quentin Perret
2019-03-28 10:13 ` [PATCH 3/3] thermal: cpu_cooling: Migrate to using the EM framework Quentin Perret
2019-03-28 20:23 ` Daniel Lezcano
2019-03-29 9:16 ` Quentin Perret
2019-03-29 17:17 ` Daniel Lezcano
2019-04-10 5:44 ` Viresh Kumar
2019-04-10 8:57 ` Quentin Perret
2019-04-10 10:14 ` Viresh Kumar
2019-04-10 10:36 ` Quentin Perret
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f99acdf-3f9a-5419-b1b5-1bcb9b36dbb6@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=amit.kachhap@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=edubezval@gmail.com \
--cc=ionela.voinescu@arm.com \
--cc=javi.merino@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=quentin.perret@arm.com \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
--cc=viresh.kumar@linaro.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).