From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932992AbeAXEiW (ORCPT ); Tue, 23 Jan 2018 23:38:22 -0500 Received: from mail-dm3nam03on0057.outbound.protection.outlook.com ([104.47.41.57]:39712 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932564AbeAXEiS (ORCPT ); Tue, 23 Jan 2018 23:38:18 -0500 Subject: Re: [PATCH v3] vfio/type1: Adopt fast IOTLB flush interface when unmap IOVAs To: Alex Williamson Cc: kvm@vger.kernel.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, joro@8bytes.org, jroedel@suse.de References: <1516595377-4681-1-git-send-email-suravee.suthikulpanit@amd.com> <20180123150452.03a42c53@w520.home> From: Suravee Suthikulpanit Message-ID: <1fb32e87-80f9-27e0-affe-afed3add7306@amd.com> Date: Wed, 24 Jan 2018 11:38:04 +0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180123150452.03a42c53@w520.home> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.53.123] X-ClientProxiedBy: YQXPR0101CA0067.CANPRD01.PROD.OUTLOOK.COM (52.132.74.44) To MWHPR12MB1741.namprd12.prod.outlook.com (10.175.55.12) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: edcb9e82-cf15-4173-1a42-08d562e44916 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(5600026)(4604075)(48565401081)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603307)(7153060)(7193020);SRVR:MWHPR12MB1741; X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1741;3:0euK8u39AN2bSGrRnJHc6moD7jm8CZ7+CgwOW1CiedxmR1nxdP3xd8c6IgdcSwPJmOMrNxPOwVSS/1E+Wf5ws7k7Eq6i94BujLDbRag6HlB3QpwKgi8e/oL3KKN3VeVM8FHo17un2GEtVtG+Awov0hUW9jGCpngDcfvnYt9LKEAOpt02ogM8L9Z2UMPzPbppSQzrBa19uVdafR1wmLBNUJjqa3V8ROmf9keUGfRdzZQHqNc97VzvP99h7LoiS6Ti;25:GHyIyiK+S3WqjpZQZD8PMjd4K9NBZKB+9kqdySrQlNtKJIraUh78IspJ/ztqAuEFC6Js5Phj9PGI83DRmcM9wCsU1eMAbs54XArrrljAUm6LVv9bLYRFShLW8UQyBH+3Vxgyfpx+CUUgwY/zgFX/pxFknHcFN8kLtNTshzY2ke57xBv6qYFKcwQzwc+S+KmAQNQixFgd5fm+MLdWgiGNJg+oC49oYPA/eKmkayuRRnJojadawgnyoZ8eEfMYbEaUJHGS0zy7ivyB8PyqJQJ/YrDgz9JDQFIt7U1Bl/326ICgpSMNcoPXwm+lJLVbBMboe0asBvnFBJ1QZ7Mo7pJKeA==;31:v1Be6gbg94jEBWBYmXefhHGz+KM3zCSu0TLMC/kExEr+T+4kXV6J7IIEIEfMwC1dMzSHG1P3NmTV5CVAyKmzlvmGrSUfdZyfbKXSqaU/h46S5RtFa2J+/BRhLgMBR14FGjHClRCHbpcn2vSVsGJl6SeZ0lh754IlmxIn3t27cNrhMg0Afxxb/Bha7xjwiqGNayTXIvePDgv5WBi2Yeq1kvfiyMFrezGh8g35yOWeB2M= X-MS-TrafficTypeDiagnostic: MWHPR12MB1741: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Suravee.Suthikulpanit@amd.com; X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1741;20:5bPibHCDENElttBt4mXGyT2VtWltJAy2SoJ+eC9CSw7SM0c5/t9avssFsotDfYP6F5y7b98iShXnWwTT1JqQtwA35neeW70p2cIX5tYMModcJN9HX+UxcFrTj6mOTgBIYwQtC1jssrTSbY9NXKxME4enJaf8rolqe7iZmRLxAmfHxqxt0P+pRL3tsrLrb53QrSUXZsusDSdHfD2ce8FjQz+ByZ9aVbvki2p00FNVZQ4FBLNTA1pTsOKMoAvBitFL+rp+Rtowg/pUtQbFufjdv8THT+I945OOxUEC2/FP10q8+bOg5quYuk/C7tSvhat0307N8nIJe3I8/a1AhIC9sPustCMTwzzgLNcDZlEuryjbE6VM/uwuJNGiy3qOYuyIFc5v8uiQLMa/iIPYCkvKFLO7+ayw1blG9vOrWYjBE04m4PtBpIg9vE8gl0NpoJafZUzB+Y3Wvw406Jse616IbZ5fEJr8JXPwt0hQwiGKy07sZJXnhhRrb6wZ93w1KLTn;4:pZ820rKOVTKD2dxnNkRnkIGUGW+Lju5QXfXP93YUV8JWWZEvYQa10BR7s6xoPwcQ/bZYzTmq52F134rIGaU/iE0IiE06mIgeb8l23M36Ts3aOTmIPa4j5QpwCpIBTnSEwIRO3hpcuYMithcgyhq117AN16KAmRbhypZSutUL1SD7hlPuDiHokyJrOOQLJhXf4jUIZ+J/SjNC/p1/YF2p53mDiCXdOh4gxH4L9Z9VwZJST1UrnUHJDZ+6GgM4nxA4XNeXokg0r/wP2qgJyixFGQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040501)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(3231023)(2400081)(944501161)(6055026)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123562045)(20161123558120)(20161123564045)(6072148)(201708071742011);SRVR:MWHPR12MB1741;BCL:0;PCL:0;RULEID:;SRVR:MWHPR12MB1741; X-Forefront-PRVS: 056297E276 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(366004)(346002)(396003)(39380400002)(376002)(39860400002)(189003)(199004)(25786009)(58126008)(5660300001)(65826007)(316002)(16526018)(83506002)(86362001)(68736007)(478600001)(64126003)(72206003)(47776003)(50466002)(66066001)(65956001)(67846002)(6666003)(65806001)(2950100002)(6916009)(2906002)(106356001)(8936002)(97736004)(8676002)(3846002)(6116002)(53546011)(386003)(6486002)(53416004)(81156014)(81166006)(36756003)(76176011)(230700001)(31696002)(229853002)(26005)(4326008)(52116002)(7696005)(23676004)(2486003)(52146003)(31686004)(105586002)(6246003)(53936002)(7736002)(305945005);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR12MB1741;H:wsp092964wss.amd.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtNV0hQUjEyTUIxNzQxOzIzOlY4RHlncjU1RjQ1U3ZKVGpqSHRDV0pIbFNN?= =?utf-8?B?RG1oM0p0R1dVWm9jT2RrK3U3VmhYWnF0UDEwbFZsZGE2WmRoVHMvS2QxbEFE?= =?utf-8?B?MHlLSmQzblJ3Rk1Mb0R2YWFUQnRYUzFja0hBWkR5QXFkVUtTS1grTGxRZ2Yx?= =?utf-8?B?WER2Qzl5Smh3Q2NkMDJvVzBHWUlIZXUvSHhETGw4V2lPdnBKVE4xVENVT1lZ?= =?utf-8?B?aGRvY2FQUEg3Um5OTlNoUTByaWRyRDMrOUdhSkJmblRFQnZ6cWNRNy91Z3FV?= =?utf-8?B?bG52UTZUdUMvZzhZTWNDV0FIVythdVI4M1FuSG5tbjBxd1hvTm9lNVZubkJY?= =?utf-8?B?ME91bFBkWkw3MW9GZy9aT1hndHNwbk5XWVhTWlJ5aGYzVUlhbDgrTDY4TU9p?= =?utf-8?B?ajhkVzVzZytNZFhHaU94WVlyVHd1ay9lcnVHLytrbDU0bFUzdGxBLy90OUJI?= =?utf-8?B?VlEzcnB1NnV1ZUJBaFBMUG96L2hMbXhJSEo3U216UENRNUJ6bzdHd3Nvdmcr?= =?utf-8?B?RjdhWExxYXhDMTcxMUtnQ2lSL1B4cVRxNjNlSUZ6NkRrRDB6M2pXYklqdndD?= =?utf-8?B?N291Wmw1aWVPaEJ5WEVjRXNwZzBYYXdzTVBkQ3dUbmlUSFhLVXhJZXRoV2lO?= =?utf-8?B?UXl5V3AraTJwMkg4ZWZNQ2xnaHpiZ3ZZemZrcUdxRnR0Y3BxNTR4SHJHTHVt?= =?utf-8?B?bjhFSDJJUFFRSitUcWliN3g2N2JTelVxYy9pa0hUTW8rMWN3eGVkeDduQ3F6?= =?utf-8?B?aTJ1ekY1OFM4YVNsTzk2RGdPNWdJdzk0NGRBR3o3NUJwV0hrUGw1NHJ2Kzl0?= =?utf-8?B?NURzY3ZocVNrU1hhYUdtMzV3MCs0S2NHd0hqbURxdlRtaG0rbFFvYnJYQStF?= =?utf-8?B?OHNzeGUrQkxLUnIrTCs1NjlQRzFPNHUrMnVha2tKUWpPbFlYQlZWbVA3YnRi?= =?utf-8?B?eHNDLzRrZmdCUlBCS2o5TjZBbmJiZXlUOTNNTGhSWTZaVWlWdHNqN0lTcURK?= =?utf-8?B?S0hpMDBHZURTSjZKanVlZ2kzYkV4bVdIV2FCejFVbWVNUWU3RFQxdkRJeElz?= =?utf-8?B?NGw2NFQ0aVBuZG41RVJKcTRFS2N1V0E2Yk9mUmtzMDhLS284akIzVzcyNEJu?= =?utf-8?B?cXByV1VwRlBPdGxraVA4R1hRZXFORUhHb0RQbjZWOVI5NjhvVXcrQ0d1MllR?= =?utf-8?B?VGlPaTVOemFKVHhKTlJMd1ZpRFcwWVBvS2NlL1dtMXhMOStSaXpobGFsRzEz?= =?utf-8?B?OW9HMHVTcllUUVlCMitZYkd5Z0w3eG5ZRStncXpLNGhkL3c2aWZrWExjaUlr?= =?utf-8?B?QTNZRnZzRkthTmJIOC9hNzg5VG9DZTZJU0NQOTQ3bXd6blNIdDR3N0JDSXQr?= =?utf-8?B?bHRaNWtZVnFmL2l0cE5WaTJpUTVmVXpPZ1FrMHBFK1JMNG5sZllNRnllZTQ4?= =?utf-8?B?bkdyejBkdSthSWt5cGlUaTFxYktyZTk2dmg0RmN5N292RTl6RUpCd1RQYVAr?= =?utf-8?B?TmdUczg1UkE5c1pUOU51Zjk5VWtLd2VSYU05RktMeU9hU1JVMlNIa3dIMVFm?= =?utf-8?B?TjZCb2NGQ1ZaVjhtT3VGcHhvNE1SWG5nZUVkdE5UT0h5L0dCUi9oa0JJUTZa?= =?utf-8?B?K1ZzTSs3aGFHbFNVNVZFeUMzYnJKTm9zaDVySFBUTnl0UHI0ZzFjZDRMeE5s?= =?utf-8?B?dWpXWkh4MVNONWFseWdZVGNObENTbWV6V1pSUWlIWE9yaS9qVUpVcEFLbVUr?= =?utf-8?B?ZTNUMjB5YjlYVmcyMnNjM1ozTllsZXMySFpPZlkwZmxoeWdGbDJ6cXpmanVJ?= =?utf-8?B?YWVZaUFwOTF4MXk5MVp0UFRzTmJnQzczSTJHaW5sdzBlMnc9PQ==?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1741;6:gzdiQ/w3hOGEr346gKRdhWZ8QXfR0IDn4Y/hAZ2INYaGmfsECpJkKy/QCH6cakTkS995PafvBcLO4rcWsITi/oez7t5sdC5lORR0W3LNE0LBbYUxx+cwkC34TzBX3+ze65wl6E/3ftQ0TbPmEzJvX7oaoASe6it2ZRNosRJfWXolmdJOePHD7t/7toGPyVLto3paJpLv6LzU0MSUmWUgFrCVNZLrjlWbjzi3jCaqGcXkhI+fGQx2LiqrvYfKNnnOncMLgNxgw8IxNpK1YTaZdINwvwkGTcp1ZYtA04nhpucbegr3Sz8j/M+m0mnT52RHHAMV82oGGMYGPL/owMwIKRw6CAqGlnkoUDA4nVzMjCI=;5:1Vf30+AVxCW+cIR1rQCaWnOwh0mgKzUiwBjtmd5yzGUOo6jb3keAZ/eojXjV5UZTGMYd75z0YVWL61R2/Jy4amqmlLNGlZj+XmYc4bPwhsZWmHnTzloIxvT9esSjD5ursohFbOavwFfNe+NO8aPc0Q7/0Mgd3naTobCgyhOxi5s=;24:HKNon1GqDn4QtUdWm/bDQY3bfYRmRhzzoPI2/sp3q51dX360KcXWtKZAToymwaefO6u43+aM2rRJIYOgI2beVK2Ac0P59INgi9fgYLVCOcs=;7:9/jzjnOB+pzfIYfKJZPDwiqF//E8c0nCQqrPCDPNnFt4SneMkFQ0+Pr7pmUowDqi7l8Y5+WRLUWHru+MOAvImrW1PmwxR5bV3PmFhQ0um09JDE5zrSk97gpOgHg+ps8GGKeBMDP5ocbXdfuZJz+7h2mZw/mvd0LvMRExcwGNZdA5X9sNSICl/6ceQU3nX0T1/zSNwuZwFqp52dwSXC1jCyVM/xpGGnpkQthcfwwdAApgMWNFnVw13EqekTtfj5Bv SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1741;20:AtWMRVn17vnxEBb5u2wK6F1zJzV7XrPicLHZDqvxXR2Rtcx5x6zjkk+xWVeWx+my1cCzvvsC4+EYwRKu3TUaQc1Z07hcvMDNKWWrSIjo//f17Wn1893smb6ZtpSqVZSqMN6uh+aBAh89WxrQQZCzH5FzubULiRvnNcwmt3H7AzPjVIAUC9ftzG0BQot7J/zIQdbs4cyNJL1zq9exfXVNPg8fnazSjjddKPQGqjQrWJwLz8hpJluzohj2XrZkSGCx X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2018 04:38:13.0418 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: edcb9e82-cf15-4173-1a42-08d562e44916 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1741 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Alex/Joerg, On 1/24/18 5:04 AM, Alex Williamson wrote: >> +static size_t try_unmap_unpin_fast(struct vfio_domain *domain, dma_addr_t iova, >> + size_t len, phys_addr_t phys, >> + struct list_head *unmapped_regions) >> +{ >> + struct vfio_regions *entry; >> + size_t unmapped; >> + >> + entry = kzalloc(sizeof(*entry), GFP_KERNEL); >> + if (!entry) >> + return -ENOMEM; > size_t is unsigned, so pushing -ENOMEM out though this unsigned > function and the callee interpreting it as unsigned, means we're going > to see this as a very large unmap, not an error condition. Looks like > the IOMMU API has problems in this space too, ex. iommu_unmap(), Joerg? > I can clean up the APIs to use ssize_t, where it can return errors. Suravee