From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C244C433DB for ; Wed, 10 Feb 2021 12:53:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F423664DF2 for ; Wed, 10 Feb 2021 12:53:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230499AbhBJMxR (ORCPT ); Wed, 10 Feb 2021 07:53:17 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:45004 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229465AbhBJMw5 (ORCPT ); Wed, 10 Feb 2021 07:52:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612961490; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ugPjlCfZxXXobtAMOc/wdDCpv4LkRF9qteob74JQanE=; b=NywZLqJ4OQ1u3sIwBO97QFx1kxaXF49dEvRh20ZKIPRPYxzA8ipCTDDmScrpRkIO+/6MoO A16K34BcKEaAXPKB89OS6kHaWoB3Ls7RXOPmka3tYDyK6ujp8nfguZ4tMJ5vsbSoHdXw2D iZlhiXf6Kr3DKbQnVBpYtimY0Bsi33k= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-562-nZcOcRj5OQGFsSMRm8IhjA-1; Wed, 10 Feb 2021 07:51:28 -0500 X-MC-Unique: nZcOcRj5OQGFsSMRm8IhjA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3311980402C; Wed, 10 Feb 2021 12:51:24 +0000 (UTC) Received: from ovpn-115-79.ams2.redhat.com (ovpn-115-79.ams2.redhat.com [10.36.115.79]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0CD435D9C0; Wed, 10 Feb 2021 12:51:12 +0000 (UTC) Message-ID: <1fb33427fe84e20e0e41b69bf075d4ded11282ef.camel@redhat.com> Subject: Re: [v3 net-next 08/10] skbuff: reuse NAPI skb cache on allocation path (__build_skb()) From: Paolo Abeni To: Alexander Lobakin Cc: "David S. Miller" , Jakub Kicinski , Jonathan Lemon , Eric Dumazet , Dmitry Vyukov , Willem de Bruijn , Randy Dunlap , Kevin Hao , Pablo Neira Ayuso , Jakub Sitnicki , Marco Elver , Dexuan Cui , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Taehee Yoo , Cong Wang , =?ISO-8859-1?Q?Bj=F6rn_T=F6pel?= , Miaohe Lin , Guillaume Nault , Yonghong Song , zhudi , Michal Kubecek , Marcelo Ricardo Leitner , Dmitry Safonov <0x7f454c46@gmail.com>, Yang Yingliang , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Edward Cree , Jesper Dangaard Brouer Date: Wed, 10 Feb 2021 13:51:11 +0100 In-Reply-To: <20210210122414.8064-1-alobakin@pm.me> References: <20210209204533.327360-1-alobakin@pm.me> <20210209204533.327360-9-alobakin@pm.me> <20210210122414.8064-1-alobakin@pm.me> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-2.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2021-02-10 at 12:25 +0000, Alexander Lobakin wrote: > Paolo Abeni on Wed, 10 Feb 2021 11:21:06 +0100 wrote: > > Perhaps giving the device drivers the ability to opt-in on this infra > > via a new helper - as done back then with napi_consume_skb() - would > > make this change safer? > > That's actually a very nice idea. There's only a little in the code > to change to introduce an ability to take heads from the cache > optionally. This way developers could switch to it when needed. > > Thanks for the suggestions! I'll definitely absorb them into the code > and give it a test. Quick reply before is too late. I suggest to wait a bit for others opinions before coding - if others dislike this I would regret wasting your time. Cheers, Paolo