From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Amrit Anand <quic_amrianan@quicinc.com>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, kernel@quicinc.com,
Elliot Berman <quic_eberman@quicinc.com>
Subject: Re: [PATCH 1/2] dt-bindings: hwinfo: Introduce board-id
Date: Tue, 23 Jan 2024 13:09:07 +0100 [thread overview]
Message-ID: <1fc9815e-76dd-41d7-aa1a-caa72ef4ad34@linaro.org> (raw)
In-Reply-To: <1705749649-4708-2-git-send-email-quic_amrianan@quicinc.com>
On 20/01/2024 12:20, Amrit Anand wrote:
> From: Elliot Berman <quic_eberman@quicinc.com>
>
>
> How is this better than Qualcomm's qcom,msm-id/qcom,board-id?
> -------------------------------------------------------------
> The selection process for devicetrees was Qualcomm-specific and not
> useful for other devices and bootloaders that were not developed by
> Qualcomm because a complex algorithm was used to implement. Board-ids
> provide a matching solution that can be implemented by bootloaders
> without introducing vendor-specific code. Qualcomm uses three
> devicetree properties: msm-id (interchangeably: soc-id), board-id, and
> pmic-id. This does not scale well for use casese which use identifiers,
> for example, to distinguish between a display panel. For a display
> panel, an approach could be to add a new property: display-id,
> but now bootloaders need to be updated to also read this property. We
> want to avoid requiring to update bootloaders with new hardware
Some mis-indentation in two lines above.
> identifiers: a bootloader need only recognize the identifiers it can
> handle.
>
> Signed-off-by: Elliot Berman <quic_eberman@quicinc.com>
> Signed-off-by: Amrit Anand <quic_amrianan@quicinc.com>
> ---
> .../devicetree/bindings/hwinfo/board-id.yaml | 53 ++++++++++++++++++++++
> 1 file changed, 53 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwinfo/board-id.yaml
>
> diff --git a/Documentation/devicetree/bindings/hwinfo/board-id.yaml b/Documentation/devicetree/bindings/hwinfo/board-id.yaml
I think we should add it to dtschema, because bootloaders are using these.
> new file mode 100644
> index 0000000..82d5ff7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwinfo/board-id.yaml
> @@ -0,0 +1,53 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwinfo/board-id.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Board Identifier for Devicetree Selection
> +
> +maintainers:
> + - Amrit Anand <quic_amrianan@quicinc.com>
> + - Elliot Berman <quic_eberman@quicinc.com>
> +
> +description: |
Do not need '|' unless you need to preserve formatting.
> + Device manufacturers frequently ship multiple boards under a single
> + software package. These software packages will ship multiple devicetree
> + blobs and require some mechanism to pick the correct DTB for the board
> + the software package was deployed. board-id provides a mechanism for
> + bootloaders to select the appropriate DTB which is vendor/OEM-agnostic.
> +
> +select:
> + anyOf:
> + - required:
> + - 'board-id'
> + - required:
> + - 'board-id-types'
> + - required:
> + - '#board-id-cells'
I don't fully get why do you need this select. Isn't the schema selected
by nodename? Or maybe it is for the final required: but then this could
be just set of dependencies.
> +
> +properties:
> + $nodename:
> + const: "/"
Blank line.
> + board-id:
> + $ref: /schemas/types.yaml#/definitions/uint32-matrix
> + description: |
Do not need '|' unless you need to preserve formatting.
> + A list of identifiers that can be used to match with this devicetree.
s/devicetree/Devicetree/ ?
> + The interpretatation of each cell can be matched with the
Typo: interpretation
> + board-id-type at the same index.
> +
> + board-id-types:
> + $ref: /schemas/types.yaml#/definitions/non-unique-string-array
> + description:
> + Defines the type of each cell, indicating to the DeviceTree selection
s/DeviceTree/Devicetree/ ?
> + mechanism how to parse the board-id.
> +
> + '#board-id-cells':
What are the cells for?
> + minimum: 1
> +
> +required:
> + - board-id
> + - board-id-types
> + - '#board-id-cells'
> +
> +additionalProperties: true
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-01-23 12:09 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-20 11:20 [PATCH 0/2] Add board-id support for multiple DT selection Amrit Anand
2024-01-20 11:20 ` [PATCH 1/2] dt-bindings: hwinfo: Introduce board-id Amrit Anand
2024-01-20 12:36 ` Rob Herring
2024-01-20 19:10 ` Trilok Soni
2024-01-22 10:10 ` Amrit Anand
2024-01-23 11:50 ` Krzysztof Kozlowski
2024-01-23 17:18 ` Conor Dooley
2024-01-23 18:51 ` Elliot Berman
2024-01-23 20:05 ` Trilok Soni
2024-01-24 12:44 ` Amrit Anand
2024-01-23 12:09 ` Krzysztof Kozlowski [this message]
2024-01-24 12:42 ` Amrit Anand
2024-01-25 10:40 ` Krzysztof Kozlowski
2024-01-24 15:00 ` Rob Herring
2024-01-20 11:20 ` [PATCH 2/2] dt-bindings: hwinfo: Add Qualcomm's board-id types Amrit Anand
2024-01-20 12:36 ` Rob Herring
2024-01-20 13:32 ` Konrad Dybcio
2024-01-22 10:07 ` Amrit Anand
2024-01-22 18:10 ` Elliot Berman
2024-01-22 19:27 ` Dmitry Baryshkov
2024-01-24 12:47 ` Amrit Anand
2024-01-21 2:05 ` kernel test robot
2024-01-22 18:12 ` Elliot Berman
2024-01-20 13:04 ` [PATCH 0/2] Add board-id support for multiple DT selection Konrad Dybcio
2024-01-22 17:50 ` Elliot Berman
2024-01-24 14:56 ` Rob Herring
2024-02-02 5:00 ` Amrit Anand
2024-02-14 12:56 ` Amrit Anand
2024-02-14 13:12 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1fc9815e-76dd-41d7-aa1a-caa72ef4ad34@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@quicinc.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_amrianan@quicinc.com \
--cc=quic_eberman@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).