From: Ziyang Xuan <william.xuanziyang@huawei.com>
To: <davem@davemloft.net>, <kuba@kernel.org>, <netdev@vger.kernel.org>
Cc: <edumazet@google.com>, <sakiwit@gmail.com>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH net-next 3/3] net: ipvtap: fix error comments
Date: Mon, 14 Mar 2022 19:13:25 +0800 [thread overview]
Message-ID: <1fdd040200b495add1020f4a0890ce8d87267334.1647255926.git.william.xuanziyang@huawei.com> (raw)
In-Reply-To: <cover.1647255926.git.william.xuanziyang@huawei.com>
Use "macvlan" comment inappropriately in ipvtap module.
Fix them with "ipvlan" comment.
Signed-off-by: Ziyang Xuan <william.xuanziyang@huawei.com>
---
drivers/net/ipvlan/ipvtap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ipvlan/ipvtap.c b/drivers/net/ipvlan/ipvtap.c
index ef02f2cf5ce1..c130cfb30822 100644
--- a/drivers/net/ipvlan/ipvtap.c
+++ b/drivers/net/ipvlan/ipvtap.c
@@ -83,7 +83,7 @@ static int ipvtap_newlink(struct net *src_net, struct net_device *dev,
INIT_LIST_HEAD(&vlantap->tap.queue_list);
- /* Since macvlan supports all offloads by default, make
+ /* Since ipvlan supports all offloads by default, make
* tap support all offloads also.
*/
vlantap->tap.tap_features = TUN_OFFLOADS;
@@ -95,7 +95,7 @@ static int ipvtap_newlink(struct net *src_net, struct net_device *dev,
if (err)
return err;
- /* Don't put anything that may fail after macvlan_common_newlink
+ /* Don't put anything that may fail after ipvlan_link_new
* because we can't undo what it does.
*/
err = ipvlan_link_new(src_net, dev, tb, data, extack);
--
2.25.1
prev parent reply other threads:[~2022-03-14 10:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-14 11:11 [PATCH net-next 0/3] net: ipvlan: fix potential UAF problem for phy_dev Ziyang Xuan
2022-03-14 11:12 ` [PATCH net-next 1/3] " Ziyang Xuan
2022-03-14 17:24 ` Eric Dumazet
2022-03-15 2:21 ` Ziyang Xuan (William)
2022-03-14 11:12 ` [PATCH net-next 2/3] net: ipvlan: add net device refcount tracker Ziyang Xuan
2022-03-14 11:13 ` Ziyang Xuan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1fdd040200b495add1020f4a0890ce8d87267334.1647255926.git.william.xuanziyang@huawei.com \
--to=william.xuanziyang@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sakiwit@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).