From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751821AbdCPIAH (ORCPT ); Thu, 16 Mar 2017 04:00:07 -0400 Received: from lelnx194.ext.ti.com ([198.47.27.80]:34408 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751777AbdCPIAE (ORCPT ); Thu, 16 Mar 2017 04:00:04 -0400 Subject: Re: [PATCH 2/4] ARM: OMAP2+ hwmod: Allow modules to disable HW_AUTO To: Tony Lindgren References: <1489405996-10718-1-git-send-email-rogerq@ti.com> <1489405996-10718-3-git-send-email-rogerq@ti.com> <20170314154843.GD20572@atomide.com> CC: , , , , , From: Roger Quadros Message-ID: <1ffd0881-9076-04b0-62bf-85b02dd7bbf3@ti.com> Date: Thu, 16 Mar 2017 09:59:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170314154843.GD20572@atomide.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tony, On 14/03/17 17:48, Tony Lindgren wrote: > * Roger Quadros [170313 04:55]: > >> --- a/arch/arm/mach-omap2/omap_hwmod.c >> +++ b/arch/arm/mach-omap2/omap_hwmod.c >> @@ -2149,7 +2149,7 @@ static int _idle(struct omap_hwmod *oh) >> _idle_sysc(oh); >> _del_initiator_dep(oh, mpu_oh); >> >> - if (oh->clkdm) >> + if (oh->clkdm && !(oh->flags & HWMOD_CLKDM_NOAUTO)) >> clkdm_deny_idle(oh->clkdm); >> >> if (oh->flags & HWMOD_BLOCK_WFI) > > Is this change to _idle() really needed? It seems that the > clkdm_deny_idle() there is paired with the clkdm_allow_idle() > later on in the same function? > You are right. This change to _idle() is unnecessary. I'll send an update. -- cheers, -roger