From: Jerome Brunet <jbrunet@baylibre.com>
To: Alexandre Mergnat <amergnat@baylibre.com>
Cc: khilman@baylibre.com, sboyd@kernel.org, narmstrong@baylibre.com,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
baylibre-upstreaming@groups.io,
Alexandre Mergnat <amergnat@baylibre.com>
Subject: Re: [PATCH 3/8] clk: meson: gxbb: migrate to the new parent description method
Date: Thu, 25 Jul 2019 16:49:51 +0200 [thread overview]
Message-ID: <1j5znqxj74.fsf@starbuckisacylon.baylibre.com> (raw)
In-Reply-To: <20190722095425.14193-4-amergnat@baylibre.com>
On Mon 22 Jul 2019 at 11:54, Alexandre Mergnat <amergnat@baylibre.com> wrote:
> @@ -1592,13 +1737,29 @@ static struct clk_regmap gxbb_vid_pll_div = {
> .hw.init = &(struct clk_init_data) {
> .name = "vid_pll_div",
> .ops = &meson_vid_pll_div_ro_ops,
> - .parent_names = (const char *[]){ "hdmi_pll" },
> + .parent_data = &(const struct clk_parent_data) {
> + /*
> + * This clock is declared here for GXL and GXBB SoC, so
> + * we must use string name to set this parent to avoid
> + * pointer issue.
> + */
I don't really get the issue with this comment.
How about:
/*
* Note:
* gxl and gxbb have different hdmi_plls (with different struct clk_hw).
* We fallback to the global naming string mechanism so vid_pll_div picks
* up the appropriate one.
*/
> + .name = "hdmi_pll",
> + .index = -1,
> + },
> .num_parents = 1,
> .flags = CLK_SET_RATE_PARENT | CLK_GET_RATE_NOCACHE,
> },
> };
next prev parent reply other threads:[~2019-07-25 14:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 9:54 [PATCH 0/8] clk: meson: ee: use the new parent description method Alexandre Mergnat
2019-07-22 9:54 ` [PATCH 1/8] clk: meson: g12a: move clock declaration to dependency order Alexandre Mergnat
2019-07-22 9:54 ` [PATCH 2/8] clk: meson: g12a: migrate to the new parent description method Alexandre Mergnat
2019-07-22 9:54 ` [PATCH 3/8] clk: meson: gxbb: " Alexandre Mergnat
2019-07-25 14:49 ` Jerome Brunet [this message]
2019-07-25 17:09 ` Chen-Yu Tsai
2019-07-26 10:27 ` Alexandre Mergnat
2019-07-22 9:54 ` [PATCH 4/8] clk: meson: axg: " Alexandre Mergnat
2019-07-22 9:54 ` [PATCH 5/8] clk: meson: meson8b: " Alexandre Mergnat
2019-07-22 9:54 ` [PATCH 6/8] clk: meson: clk-regmap: migrate to " Alexandre Mergnat
2019-07-22 9:54 ` [PATCH 7/8] clk: meson: remove ee input bypass clocks Alexandre Mergnat
2019-07-22 9:54 ` [PATCH 8/8] clk: meson: remove clk input helper Alexandre Mergnat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1j5znqxj74.fsf@starbuckisacylon.baylibre.com \
--to=jbrunet@baylibre.com \
--cc=amergnat@baylibre.com \
--cc=baylibre-upstreaming@groups.io \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).