From: Jerome Brunet <jbrunet@baylibre.com>
To: Stephen Boyd <sboyd@kernel.org>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
khilman@baylibre.com, linux-amlogic@lists.infradead.org,
narmstrong@baylibre.com
Cc: robh+dt@kernel.org, mark.rutland@arm.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH v2 2/5] clk: meson: add a driver for the Meson8/8b/8m2 DDR clock controller
Date: Tue, 12 Nov 2019 18:20:20 +0100 [thread overview]
Message-ID: <1jd0dxf1uz.fsf@starbuckisacylon.baylibre.com> (raw)
In-Reply-To: <20191108221652.32FA2206C3@mail.kernel.org>
>> +static const struct of_device_id meson8_ddr_clkc_match_table[] = {
>> + { .compatible = "amlogic,meson8-ddr-clkc" },
>> + { .compatible = "amlogic,meson8b-ddr-clkc" },
>> + { /* sentinel */ },
>
> Super nitpick, drop the comma above so that nothing can follow this.
I don't think it is worth reposting the series Martin.
If it is ok with you, I'll just apply it with Stephen comments
In the future, I would prefer if you could separate the series for clock
(intended for Neil and myself) and the DT one (intended for Kevin)
Thx
>
>> +};
>> +
>> +static struct platform_driver meson8_ddr_clkc_driver = {
>> + .probe = meson8_ddr_clkc_probe,
>> + .driver = {
>> + .name = "meson8-ddr-clkc",
>> + .of_match_table = meson8_ddr_clkc_match_table,
>> + },
>> +};
>> +
>> +builtin_platform_driver(meson8_ddr_clkc_driver);
>> --
>> 2.23.0
>>
next prev parent reply other threads:[~2019-11-12 17:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-27 16:23 [PATCH v2 0/5] add the DDR clock controller on Meson8 and Meson8b Martin Blumenstingl
2019-10-27 16:23 ` [PATCH v2 1/5] dt-bindings: clock: add the Amlogic Meson8 DDR clock controller binding Martin Blumenstingl
2019-11-08 22:07 ` Stephen Boyd
2019-10-27 16:23 ` [PATCH v2 2/5] clk: meson: add a driver for the Meson8/8b/8m2 DDR clock controller Martin Blumenstingl
2019-11-08 22:16 ` Stephen Boyd
2019-11-12 17:20 ` Jerome Brunet [this message]
2019-11-12 20:52 ` Martin Blumenstingl
2019-11-16 16:52 ` Martin Blumenstingl
2019-10-27 16:23 ` [PATCH v2 3/5] clk: meson: meson8b: use of_clk_hw_register to register the clocks Martin Blumenstingl
2019-11-08 22:07 ` Stephen Boyd
2019-10-27 16:23 ` [PATCH v2 4/5] ARM: dts: meson8: add the DDR clock controller Martin Blumenstingl
2019-10-27 16:23 ` [PATCH v2 5/5] ARM: dts: meson8b: " Martin Blumenstingl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1jd0dxf1uz.fsf@starbuckisacylon.baylibre.com \
--to=jbrunet@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).