From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72516C433F5 for ; Fri, 3 Sep 2021 12:18:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 51412610CF for ; Fri, 3 Sep 2021 12:18:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349270AbhICMTV (ORCPT ); Fri, 3 Sep 2021 08:19:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349343AbhICMTT (ORCPT ); Fri, 3 Sep 2021 08:19:19 -0400 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8965C061575 for ; Fri, 3 Sep 2021 05:18:19 -0700 (PDT) Received: by mail-wr1-x42b.google.com with SMTP id z4so7954671wrr.6 for ; Fri, 03 Sep 2021 05:18:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version; bh=gJPMJG0eBq0LfThk7r5TKlTW6PuUo5YuJeYmkTHTj58=; b=oEqxg/iOTlszZ3iRH5PVqRldvdbboM2dzQ7gKRqjzT18OPEIQEd/Q3qVBHwwT09D4b e2JONtxnDUD48aWG92h/MCA7hYWGmA0oQxHkja0/YhORIsw9ZgNYkTPPbttA9PEVec+v ZoAPSj95MZHHrjNKGJD2VSaU8JRn6St8W/sYO1ffqTk+3a0H1wBg3846gtHfFA3A4uTx mqQRLhFDsVT07sSqFCuGb65lCAJQjVatPMEVBVTC/0yn3kJLOlCKqN6SrpsYDqfGk4xI TBD+U+oGaDMYJoc/GnP7Pia5NINbJncLwDkDyH2gWzRuqJmyTf+WVtELkbhjzrmGD0nN LGUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version; bh=gJPMJG0eBq0LfThk7r5TKlTW6PuUo5YuJeYmkTHTj58=; b=ghGzsArsxrPdVW/CW92Z8cBKsy3h3Iw2nqyPqjukmO7QXwKxIda5l84tpPuCAFkelC 3hLyu/5qyisCfRZ8zbq9hG66kU7WQb6pGGIzLJfOuv0UhwxnO2e29EG+sy2ORgBInfNY bSBth8a5zAwfaFJOtoM4N/tj6Ub6lt5RBDAJ8RkYbNb0MzCj2F65E/BGL/82IjsytVaZ K3RZgASX167IhjORGvlzK8D+BYgWoVkNjzQ7FTpaDt/YDzzs8e/CAPOwNTyMyDLgQavw qbvgRVT/7M/yXu7dtweNY2/N+re96AOdC5ZewcxYSD+XVhyrPxoO3/e82GOMg/k8a7IG Ivgg== X-Gm-Message-State: AOAM530HlGmBbfw5fSWbi+vM+SX++zlDoblChAP+2CJk1+lHmM7GzrQb S7piS9lpaM6P1GNiA0jwLN5+Nw== X-Google-Smtp-Source: ABdhPJznynnEiJhuoDghrhyxKtbMef3w05fOWOEBMejj8TtxEn25hiIKQsa69zQnrlukD30UeYpgDw== X-Received: by 2002:a5d:4d8c:: with SMTP id b12mr3703080wru.232.1630671498312; Fri, 03 Sep 2021 05:18:18 -0700 (PDT) Received: from localhost (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.gmail.com with ESMTPSA id o18sm5481001wrg.23.2021.09.03.05.18.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Sep 2021 05:18:17 -0700 (PDT) References: <20210903060035.844758-1-adeep@lexina.in> <20210903060035.844758-3-adeep@lexina.in> User-agent: mu4e 1.6.5; emacs 27.1 From: Jerome Brunet To: Vyacheslav Bocharov , Neil Armstrong , Kevin Hilman Cc: linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/3] arm64: dts: meson-gxl: add support for JetHub H1 Date: Fri, 03 Sep 2021 14:10:51 +0200 In-reply-to: <20210903060035.844758-3-adeep@lexina.in> Message-ID: <1jfsulua2e.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 03 Sep 2021 at 09:00, Vyacheslav Bocharov wrote: > JetHome Jethub H1 (http://jethome.ru/jethub-h1) is a home automation controller with the following features: > > - square plastic case > - Amlogic S905W (ARM Cortex-A53) quad-core up to 1.5GHz > - no video out > - 1GB LPDDR4 > - 8/16GB eMMC flash > - 2 x USB 2.0 > - 1 x 10/100Mbps ethernet > - WiFi / Bluetooth RTL8822CS IEEE 802.11a/b/g/n/ac, Bluetooth 5.0. > - TI CC2538 + CC2592 Zigbee Wireless Module with up to 20dBm output power and Zigbee 3.0 support. > - MicroSD 2.x/3.x/4.x DS/HS cards. > - 1 x gpio LED > - ADC user Button > - DC source 5V microUSB > > Signed-off-by: Vyacheslav Bocharov > --- > arch/arm64/boot/dts/amlogic/Makefile | 1 + > .../meson-gxl-s905w-jethome-jethub-j80.dts | 241 ++++++++++++++++++ > 2 files changed, 242 insertions(+) > create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts > > diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile > index faa0a79a34f5..2c3ce7c401a5 100644 > --- a/arch/arm64/boot/dts/amlogic/Makefile > +++ b/arch/arm64/boot/dts/amlogic/Makefile > @@ -38,6 +38,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s805x-p241.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905w-p281.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905w-tx3-mini.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905d-libretech-pc.dtb > +dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905w-jethome-jethub-j80.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-gxm-khadas-vim2.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-gxm-mecool-kiii-pro.dtb > dtb-$(CONFIG_ARCH_MESON) += meson-gxm-minix-neo-u9h.dtb > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts > new file mode 100644 > index 000000000000..d67a1bc50f7b > --- /dev/null > +++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905w-jethome-jethub-j80.dts > @@ -0,0 +1,241 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Copyright (c) 2021 Vyacheslav Bocharov > + * Copyright (c) 2020 JetHome > + * Author: Aleksandr Kazantsev > + * Author: Alexey Shevelkin > + * Author: Vyacheslav Bocharov > +*/ > + > +/dts-v1/; > + > +#include "meson-gxl.dtsi" > + > +/ { > + memory@0 { > + device_type = "memory"; > + reg = <0x0 0x0 0x0 0x40000000>; > + }; > + > + reserved-memory { > + linux,cma { > + size = <0x0 0x1000000>; > + }; > + }; > + > + aliases { > + serial0 = &uart_AO; /* Console */ > + serial1 = &uart_A; /* Bluetooth */ > + serial2 = &uart_AO_B; /* Wireless module 1 */ > + serial3 = &uart_C; /* Wireless module 2 */ > + ethernet0 = ðmac; > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > + > + vddio_ao18: regulator-vddio_ao18 { > + compatible = "regulator-fixed"; > + regulator-name = "VDDIO_AO18"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + }; > + > + vddio_boot: regulator-vddio_boot { > + compatible = "regulator-fixed"; > + regulator-name = "VDDIO_BOOT"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + }; > + > + vddao_3v3: regulator-vddao_3v3 { > + compatible = "regulator-fixed"; > + regulator-name = "VDDAO_3V3"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + }; > + > + vcc_3v3: regulator-vcc_3v3 { > + compatible = "regulator-fixed"; > + regulator-name = "VCC_3V3"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + }; > + > + emmc_pwrseq: emmc-pwrseq { > + compatible = "mmc-pwrseq-emmc"; > + reset-gpios = <&gpio BOOT_9 GPIO_ACTIVE_LOW>; > + }; > + > + wifi32k: wifi32k { > + compatible = "pwm-clock"; > + #clock-cells = <0>; > + clock-frequency = <32768>; > + pwms = <&pwm_ef 0 30518 0>; /* PWM_E at 32.768KHz */ > + }; > + > + sdio_pwrseq: sdio-pwrseq { > + compatible = "mmc-pwrseq-simple"; > + reset-gpios = <&gpio GPIOX_6 GPIO_ACTIVE_LOW>; > + clocks = <&wifi32k>; > + clock-names = "ext_clock"; > + }; > +}; > + > +&efuse { > + sn: sn@14 { > + reg = <0x14 0x10>; > + }; already defined in meson-gx.dtsi also, what about a new line between the nodes ? > + bt_mac: bt_mac@6 { > + reg = <0x6 0x6>; > + }; > + wifi_mac: wifi_mac@C { > + reg = <0xc 0x6>; > + }; > + serial: serial@32 { > + reg = <0x32 0x20>; > + }; Isn't serial and sn the same thing ? > +}; > + > +ð_mac { > + reg = <0x0 0x6>; > +}; > + > +&bid { > + reg = <0x12 0x20>; > +}; > + > + Suggest running checkpatch > +&usb { > + status = "okay"; > + dr_mode = "host"; > +}; > + > +&pwm_ef { > + status = "okay"; > + pinctrl-0 = <&pwm_e_pins>; > + pinctrl-names = "default"; > + clocks = <&clkc CLKID_FCLK_DIV4>; > + clock-names = "clkin0"; > +}; > + > +&saradc { > + status = "okay"; > + vref-supply = <&vddio_ao18>; > +}; > + > +/* Wireless SDIO Module */ > +&sd_emmc_a { > + status = "okay"; > + pinctrl-0 = <&sdio_pins>; > + pinctrl-1 = <&sdio_clk_gate_pins>; > + pinctrl-names = "default", "clk-gate"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + bus-width = <4>; > + cap-sd-highspeed; > + max-frequency = <50000000>; > + > + non-removable; > + disable-wp; > + > + /* WiFi firmware requires power to be kept while in suspend */ > + keep-power-in-suspend; > + > + mmc-pwrseq = <&sdio_pwrseq>; > + > + vmmc-supply = <&vddao_3v3>; > + vqmmc-supply = <&vddio_boot>; > +}; > + > +/* SD card */ > +&sd_emmc_b { > + status = "okay"; > + pinctrl-0 = <&sdcard_pins>; > + pinctrl-1 = <&sdcard_clk_gate_pins>; > + pinctrl-names = "default", "clk-gate"; > + > + bus-width = <4>; > + cap-sd-highspeed; > + max-frequency = <50000000>; > + disable-wp; > + > + cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_LOW>; > + > + vmmc-supply = <&vddao_3v3>; > + vqmmc-supply = <&vddio_boot>; > +}; > + > +/* eMMC */ > +&sd_emmc_c { > + status = "okay"; > + pinctrl-0 = <&emmc_pins>, <&emmc_ds_pins>; > + pinctrl-1 = <&emmc_clk_gate_pins>; > + pinctrl-names = "default", "clk-gate"; > + > + bus-width = <8>; > + cap-mmc-highspeed; > + max-frequency = <200000000>; > + non-removable; > + disable-wp; > + mmc-ddr-1_8v; > + mmc-hs200-1_8v; > + > + mmc-pwrseq = <&emmc_pwrseq>; > + vmmc-supply = <&vcc_3v3>; > + vqmmc-supply = <&vddio_boot>; > +}; > + > +/* Console UART */ > +&uart_AO { > + status = "okay"; > + pinctrl-0 = <&uart_ao_a_pins>; > + pinctrl-names = "default"; > +}; > + > +/* S905W only has access to its internal PHY */ > +ðmac { > + status = "okay"; > + phy-mode = "rmii"; > + phy-handle = <&internal_phy>; > +}; > + > +&internal_phy { > + status = "okay"; > + pinctrl-0 = <ð_link_led_pins>, <ð_act_led_pins>; > + pinctrl-names = "default"; > +}; > + > +&uart_A { > + status = "okay"; > + pinctrl-0 = <&uart_a_pins>, <&uart_a_cts_rts_pins>; > + pinctrl-names = "default"; > + uart-has-rtscts; > +}; > + > +&uart_C { > + status = "okay"; > + pinctrl-0 = <&uart_c_pins>; > + pinctrl-names = "default"; > +}; > + > +&uart_AO_B { > + status = "okay"; > + pinctrl-0 = <&uart_ao_b_pins>, <&uart_ao_b_cts_rts_pins>; > + pinctrl-names = "default"; > + uart-has-rtscts; > +}; > + > +&i2c_B { > + status = "okay"; > + pinctrl-names = "default"; > + pinctrl-0 = <&i2c_b_pins>; > + > + pcf8563: pcf8563@51 { > + compatible = "nxp,pcf8563"; > + reg = <0x51>; > + status = "okay"; > + }; > +};