From: Jerome Brunet <jbrunet@baylibre.com>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Kevin Hilman <khilman@baylibre.com>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-amlogic@lists.infradead.org
Subject: Re: [PATCH 1/6] ASoC: codec2codec: run callbacks in order
Date: Thu, 25 Jul 2019 15:21:40 +0200 [thread overview]
Message-ID: <1jlfwmxna3.fsf@starbuckisacylon.baylibre.com> (raw)
In-Reply-To: <20190725130016.GC4213@sirena.org.uk>
On Thu 25 Jul 2019 at 14:00, Mark Brown <broonie@kernel.org> wrote:
> On Wed, Jul 24, 2019 at 06:24:00PM +0200, Jerome Brunet wrote:
>> When handling dai_link events on codec to codec links, run all .startup()
>> callbacks on sinks and sources before running any .hw_params(). Same goes
>> for hw_free() and shutdown(). This is closer to the behavior of regular
>> dai links
>
> This looks good but needs rebasing against -next due to Morimoto-san's
> recent DAI changes:
>
> CC sound/soc/soc-dapm.o
> sound/soc/soc-dapm.c: In function ‘snd_soc_dai_link_event’:
> sound/soc/soc-dapm.c:3857:10: error: implicit declaration of function ‘soc_dai_hw_params’; did you mean ‘snd_soc_dai_hw_params’? [-Werror=implicit-function-declaration]
> ret = soc_dai_hw_params(&substream, params, source);
> ^~~~~~~~~~~~~~~~~
> snd_soc_dai_hw_params
I did rebase against next and saw Morimoto-san's patchset. I must have
messed up when formatting the patches, sorry about that. I'll resend.
next prev parent reply other threads:[~2019-07-25 13:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 16:23 [PATCH 0/6] ASoC: improve codec to codec link support Jerome Brunet
2019-07-24 16:24 ` [PATCH 1/6] ASoC: codec2codec: run callbacks in order Jerome Brunet
2019-07-25 13:00 ` Mark Brown
2019-07-25 13:21 ` Jerome Brunet [this message]
2019-07-24 16:24 ` [PATCH 2/6] ASoC: codec2codec: name link using stream direction Jerome Brunet
2019-07-24 16:24 ` [PATCH 3/6] ASoC: codec2codec: deal with params when necessary Jerome Brunet
2019-07-25 12:55 ` Mark Brown
2019-07-25 13:25 ` Jerome Brunet
2019-07-24 16:24 ` [PATCH 4/6] ASoC: create pcm for codec2codec links as well Jerome Brunet
2019-07-24 16:24 ` [PATCH 5/6] ASoC: codec2codec: remove ephemeral variables Jerome Brunet
2019-07-24 16:24 ` [PATCH 6/6] ASoC: codec2codec: fill some of the runtime stream parameters Jerome Brunet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1jlfwmxna3.fsf@starbuckisacylon.baylibre.com \
--to=jbrunet@baylibre.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=lgirdwood@gmail.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).