From: Jerome Brunet <jbrunet@baylibre.com>
To: Jiayi.Zhou@amlogic.com, thierry.reding@gmail.com,
u.kleine-koenig@pengutronix.de, lee.jones@linaro.org,
khilman@baylibre.com, martin.blumenstingl@googlemail.com
Cc: linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] pwm: meson: external clock configuration for s4
Date: Fri, 14 Jan 2022 15:53:58 +0100 [thread overview]
Message-ID: <1jmtjybc05.fsf@starbuckisacylon.baylibre.com> (raw)
In-Reply-To: <20220114090753.34873-1-Jiayi.Zhou@amlogic.com>
On Fri 14 Jan 2022 at 17:07, <Jiayi.Zhou@amlogic.com> wrote:
> From: "Jiayi.zhou" <jiayi.zhou@amlogic.com>
>
> For PWM controller in the Meson-S4 SoC,
> PWM needs to obtain an external clock source.
> This patch tries to describe them in the DT compatible data.
>
I'm sorry but I have already commented on v1 that all the mess in here
don't seem necessary. For Reference:
"""
You trying to bypass the input selection mux. There is no reason to do
so.
Your input clocks should be
* OSC
* vid_pll
* fdiv3
* fdiv4
While the pwm driver could welcome a rework around how it deal with DT
and the clocks, this S4 chip does not warrant any change compared to
previous generation (AFAICT)
All the stuff around "extern_clk" should go away IMO.
"""
Unless you can *really* justify why this approach is required, it is
firm Nack.
prev parent reply other threads:[~2022-01-14 14:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220114090753.34873-1-Jiayi.Zhou@amlogic.com>
2022-01-14 10:16 ` [PATCH v2] pwm: meson: external clock configuration for s4 Neil Armstrong
2022-03-24 5:29 ` Jiayi Zhou
2022-01-14 14:53 ` Jerome Brunet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1jmtjybc05.fsf@starbuckisacylon.baylibre.com \
--to=jbrunet@baylibre.com \
--cc=Jiayi.Zhou@amlogic.com \
--cc=khilman@baylibre.com \
--cc=lee.jones@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).