From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F121ECAAD2 for ; Mon, 29 Aug 2022 09:48:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229726AbiH2JsY (ORCPT ); Mon, 29 Aug 2022 05:48:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60198 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229716AbiH2JsV (ORCPT ); Mon, 29 Aug 2022 05:48:21 -0400 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C852E5E335 for ; Mon, 29 Aug 2022 02:48:14 -0700 (PDT) Received: by mail-wr1-x431.google.com with SMTP id b16so1823546wru.7 for ; Mon, 29 Aug 2022 02:48:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:to:from:user-agent :references:from:to:cc; bh=yviMMnGD2NIBrfVD3zjnDAjWREiyBqmeaA8vluhbBlM=; b=MYtv7NXErfomVhACj4CvcivN5wiwJFqlN/QkD3Svj6b+WfT5ZQsEZdIQtNq5LdrJFa RMPVkYu7i4Ao/HAeEVdQI/hPwa0SOR7tS0YwhsxrvZMUfdd5jz1tEnycF0VAGFJgXxZt 4r2zyWzIvXrnVb4vivTUZvwWkFML9pIjnCB3FoRM9Y8V3Q4X+hXchhnV8fEF+FRyh9kg 4sfg6zLbTCqB391xVq4TU4s50ywE5qP/MQb03XMu2ewstmrrh316bKCwTNEJCmLNEYnk T0pV9Gz12E8gxs2Whz60vjZwFASEgdbJ+FM+vYHtNiJgXjTwNesDLcFAzehwL4QQyY1v sAcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:to:from:user-agent :references:x-gm-message-state:from:to:cc; bh=yviMMnGD2NIBrfVD3zjnDAjWREiyBqmeaA8vluhbBlM=; b=fE6TvleUI/uEk6HJz+pcLxW0Q1WrebUxHcYF3OFFQ06vTyQK0/k0KBEB5KoRzBqGLW CqbdUG3pVe74uPDWJM5X/b0S+FjFvwbhy8EObGrZwMcgD/TpjkhvDtrgxCwK+xVNWFMj ndZKSPGfPBBdjM1ec8TBzm4vnlZtwaMdCWP9YCNMZKdecYixw68y//5SXU4Muc2KyzaK bPR0ZvCK3halZgYs90rrdZinhCyBZwzBHUfl7zpLWCr7LvWT59HkZYxWD8Q9HeO8iGDO 7TiKCx1jFQ+kKKPglQvNih0cPxLW1AZ2y5V/7a3TzqGMksr08jgGOsA2ANBb93ESSP/o 1u9g== X-Gm-Message-State: ACgBeo0e30OJimZfbP0Z+1V4kP/nHkhBclO4YUanqEvrT5QwdDJsThIv zPEasjfDoeEn6b/PiUx2A2gjjQ== X-Google-Smtp-Source: AA6agR5lYEMVig3bo2NMgSo95EVg/KNxIK82zRJNlw7Kiy2jmOtoTniZzwOoPGDhG5XQe7+GIZSwaA== X-Received: by 2002:adf:ea91:0:b0:226:dce6:c344 with SMTP id s17-20020adfea91000000b00226dce6c344mr1354957wrm.3.1661766492719; Mon, 29 Aug 2022 02:48:12 -0700 (PDT) Received: from localhost (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.gmail.com with ESMTPSA id bd22-20020a05600c1f1600b003a8436e2a94sm4385979wmb.16.2022.08.29.02.48.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Aug 2022 02:48:12 -0700 (PDT) References: <20220805085716.5635-1-yu.tu@amlogic.com> <20220805085716.5635-4-yu.tu@amlogic.com> <1jiln0yzgj.fsf@starbuckisacylon.baylibre.com> User-agent: mu4e 1.8.7; emacs 28.1 From: Jerome Brunet To: Yu Tu , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , Neil Armstrong , Kevin Hilman , Michael Turquette , Stephen Boyd , Krzysztof Kozlowski , Martin Blumenstingl Subject: Re: [PATCH V3 3/6] clk: meson: S4: add support for Amlogic S4 SoC PLL clock driver Date: Mon, 29 Aug 2022 11:46:20 +0200 In-reply-to: Message-ID: <1jwnartm78.fsf@starbuckisacylon.baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 15 Aug 2022 at 14:34, Yu Tu wrote: > Hi Jerome, > > On 2022/8/10 21:47, Jerome Brunet wrote: >> [ EXTERNAL EMAIL ] >> On Fri 05 Aug 2022 at 16:57, Yu Tu wrote: >> */ [... ] >>> +#define ANACTRL_FIXPLL_CTRL0 (0x0010 << 2) >> I already commented on the "<< 2" . Remove them please. > Sorry, maybe I didn't pay attention to this comment earlier. A little bit > of a question why is this not okay? I understand isn't it better for the > compiler to help with this calculation itself? Because it is aweful to read Also please trim your replies. It is a bit annoying to search for your comments in the replies