From: Jerome Brunet <jbrunet@baylibre.com>
To: Thomas Gleixner <tglx@linutronix.de>,
Brad Harper <bjharper@gmail.com>,
Ulf Hansson <ulf.hansson@linaro.org>
Cc: Kevin Hilman <khilman@baylibre.com>,
"open list\:ARM\/Amlogic Meson..."
<linux-amlogic@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"linux-mmc\@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Marc Zyngier <maz@kernel.org>
Subject: Re: [PATCH] mmc: meson-gx: remove IRQF_ONESHOT
Date: Wed, 07 Oct 2020 13:32:47 +0200 [thread overview]
Message-ID: <1jy2ki1db4.fsf@starbuckisacylon.baylibre.com> (raw)
In-Reply-To: <87o8lf74j5.fsf@nanos.tec.linutronix.de>
On Tue 06 Oct 2020 at 17:33, Thomas Gleixner <tglx@linutronix.de> wrote:
> Brad,
>
> On Wed, Oct 07 2020 at 00:45, Brad Harper wrote:
>> I'm happy to test anything on a range of amlogic hardware with standard
>> / rt and multiple mmc devices. Ill test Jerome's patch in next 24
>> hours to report the results.
>
> please do not top-post and trim your replies.
>
>> On 6/10/2020 11:43 pm, Thomas Gleixner wrote:
>>> We rather should make interrupts which need to have their primary
>>> handler in hard interrupt context to set IRQF_NO_THREAD. That
>>> should at the same time confirm that the primary handler is RT
>>> safe.
>>>
>>> Let me stare at the core code and the actual usage sites some more.
>
> So there are a few nasties in there and I faintly remember that there
> was an assumption that interrupts which are requested with both a
> primary and a secondary handler should quiesce the device interrupt in
> the primary handler if needed. OTOH, this also enforces that the primary
> handler is RT safe, which is after a quick scan of all the usage sites
> not a given and quite some of the users rely on IRQF_ONESHOT.
>
> The below untested patch should cure the problem and keep the interrupt
> line masked if requested with IRQF_ONESHOT.
>
With arm64 defconfig on Khadas vim3, no obvious regression. Looks good.
Tested-by: Jerome Brunet <jbrunet@baylibre.com>
I did not test with RT. Brad, Could you let us know is Thomas's patch
works for you ? Thx
next prev parent reply other threads:[~2020-10-07 11:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-02 16:49 [PATCH] mmc: meson-gx: remove IRQF_ONESHOT Jerome Brunet
2020-10-05 8:22 ` Ulf Hansson
2020-10-05 8:55 ` Thomas Gleixner
2020-10-05 12:31 ` Jerome Brunet
2020-10-06 12:43 ` Thomas Gleixner
2020-10-06 13:45 ` Brad Harper
2020-10-06 15:33 ` Thomas Gleixner
2020-10-07 11:32 ` Jerome Brunet [this message]
2020-10-08 5:11 ` Brad Harper
2020-10-08 9:08 ` Ulf Hansson
2020-11-10 15:04 ` Jerome Brunet
2020-11-11 10:47 ` Ulf Hansson
2020-11-13 15:25 ` Jerome Brunet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1jy2ki1db4.fsf@starbuckisacylon.baylibre.com \
--to=jbrunet@baylibre.com \
--cc=bigeasy@linutronix.de \
--cc=bjharper@gmail.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=maz@kernel.org \
--cc=tglx@linutronix.de \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).