From: Andrea Arcangeli <andrea@suse.de>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Linux 2.2.18pre25
Date: Fri, 8 Dec 2000 01:20:52 +0100 [thread overview]
Message-ID: <20001208012052.A23992@inspiron.random> (raw)
In-Reply-To: <E1447Fx-0002vA-00@the-village.bc.nu>
In-Reply-To: <E1447Fx-0002vA-00@the-village.bc.nu>; from alan@lxorguk.ukuu.org.uk on Thu, Dec 07, 2000 at 08:03:00PM +0000
On Thu, Dec 07, 2000 at 08:03:00PM +0000, Alan Cox wrote:
>
> Ok we believe the VM crash looping printing error messages is now fixed.
Such bug can't generate crashes. Did you ever reproduced crashes on your 8Mb
486 with 2.2.18pre24?
> Marcelo finally figured it out and my 8Mb 486 has been running 2.2.18pre
> with that fix and stably[1].
diff -urN 2.2.18pre24/mm/filemap.c 2.2.18pre25/mm/filemap.c
--- 2.2.18pre24/mm/filemap.c Wed Nov 29 19:28:29 2000
+++ 2.2.18pre25/mm/filemap.c Fri Dec 8 00:41:45 2000
@@ -220,8 +220,10 @@
* throttling.
*/
- if (!try_to_free_buffers(page, wait))
+ if (!try_to_free_buffers(page, wait)) {
+ if(--count < 0) break;
goto refresh_clock;
+ }
return 1;
}
ftp://ftp.us.kernel.org/pub/linux/kernel/people/andrea/kernels/v2.2/2.2.18pre24aa1/00_account-failed-buffer-tries-1
--- 2.2.17pre19/mm/filemap.c Tue Aug 22 14:54:13 2000
+++ /tmp/filemap.c Thu Aug 24 01:05:50 2000
@@ -179,6 +179,8 @@
if ((gfp_mask & __GFP_DMA) && !PageDMA(page))
continue;
+ count--;
+
/*
* Is it a page swap page? If so, we want to
* drop it if it is no longer used, even if it
@@ -224,7 +226,7 @@
return 1;
}
- } while (--count > 0);
+ } while (count > 0);
return 0;
}
lftp> pwd
ftp://ftp.kernel.org/pub/linux/kernel/people/andrea/patches/v2.2/2.2.17pre19
^^^^^^^^^^^
lftp> ls -l account-failed-buffer-tries-1
-rw-r--r-- 1 korg korg 407 Sep 5 22:43 account-failed-buffer-tries-1
^^^^^^
lftp>
Only difference is that pre25 keeps decreasing `count' for locked, mapped and
out-of-zone pages and that means it will still fail to shrink the cache when it
looks at the unlucky part of the physical memory while the
account-failed-buffer-tries-1 intentionally doesn't decrease `count' in that
cases to avoid failing in such unlucky cases.
account-failed-buffer-tries-1 is included in VM-global-7 and it was
described in the 2.2.18pre21aa2 email to l-k (CC'ed you) in date Fri, 17 Nov
2000 18:54:43 +0100:
[..]
00_account-failed-buffer-tries-1
Account also the failed buffer tries during shrink_mmap. (me)
(this is included in the VM-global that I maintain against vanilla
2.2.x btw)
[..]
Andrea
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2000-12-08 0:51 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-12-07 20:03 Linux 2.2.18pre25 Alan Cox
2000-12-07 23:23 ` Miquel van Smoorenburg
2000-12-07 23:41 ` Alan Cox
2000-12-08 9:47 ` Willy Tarreau
2000-12-08 14:08 ` Alan Cox
2000-12-08 16:07 ` Miquel van Smoorenburg
2000-12-08 17:08 ` Alan Cox
2000-12-08 18:12 ` Philipp Rumpf
2000-12-08 0:20 ` Andrea Arcangeli [this message]
2000-12-08 0:27 ` Alan Cox
2000-12-08 0:41 ` Andrea Arcangeli
2000-12-08 0:47 ` Alan Cox
2000-12-08 1:27 ` Linus Torvalds
2000-12-08 0:44 ` Signal 11 Rainer Mager
2000-12-08 1:05 ` Jeff V. Merkey
2000-12-08 1:09 ` Michel LESPINASSE
2000-12-08 2:14 ` Rainer Mager
2000-12-08 1:20 ` Andi Kleen
2000-12-08 1:24 ` Jeff V. Merkey
2000-12-08 1:40 ` Andi Kleen
2000-12-08 1:43 ` Jeff V. Merkey
2000-12-08 1:55 ` Jeff V. Merkey
2000-12-08 19:20 ` Dr. Kelsey Hudson
2000-12-08 2:28 ` davej
2000-12-08 3:13 ` Jeff V. Merkey
2000-12-08 3:25 ` davej
2000-12-08 16:44 ` Matthew Vanecek
2000-12-08 19:43 ` Dr. Kelsey Hudson
2000-12-08 13:52 ` Alan Cox
2000-12-15 0:11 ` lamont
2000-12-08 1:58 ` Richard B. Johnson
2000-12-08 2:04 ` Peter Samuelson
2000-12-08 16:36 ` Matthew Vanecek
2000-12-08 16:49 ` Richard B. Johnson
2000-12-08 17:40 ` Peter Samuelson
2000-12-08 19:36 ` Dr. Kelsey Hudson
2000-12-08 9:46 ` David Woodhouse
2000-12-08 14:06 ` Alan Cox
2000-12-09 19:01 ` Matthew Vanecek
2000-12-09 19:20 ` davej
2000-12-09 23:31 ` Matthew Vanecek
2000-12-11 1:31 ` OOPS when using 4GB memory setting Rainer Mager
2000-12-11 0:58 ` Signal 11 Rainer Mager
2000-12-11 9:05 ` Rainer Mager
2000-12-11 13:33 ` Mike Galbraith
2000-12-11 23:24 ` Rainer Mager
2000-12-13 0:22 ` Signal 11 - the continuing saga Rainer Mager
2000-12-13 2:17 ` Jeff V. Merkey
2000-12-13 1:45 ` Rainer Mager
2000-12-13 4:29 ` Mike Galbraith
2000-12-13 9:34 ` Rainer Mager
2000-12-13 15:40 ` Mike Galbraith
2000-12-13 3:17 ` Linus Torvalds
2000-12-13 9:34 ` Rainer Mager
2000-12-13 17:43 ` Jeff V. Merkey
2000-12-13 12:10 ` R: " CMA
2000-12-11 14:14 ` Signal 11 davej
2000-12-08 16:21 ` Horst von Brand
2000-12-08 19:34 ` Mark Vojkovich
2000-12-08 23:16 ` Jeff V. Merkey
2000-12-08 22:24 ` David Woodhouse
2000-12-09 0:56 ` Jeff V. Merkey
2000-12-08 17:02 ` Linux 2.2.18pre25 Martin Kacer
2000-12-08 17:20 ` Alan Cox
2000-12-08 17:36 ` Martin Kacer
2000-12-08 18:08 ` Andrea Arcangeli
2000-12-08 18:30 ` Martin Kacer
2000-12-08 23:55 ` Alan Cox
2000-12-08 15:16 willy tarreau
2000-12-08 17:06 ` Alan Cox
2000-12-08 20:03 willy tarreau
2000-12-08 20:12 willy tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20001208012052.A23992@inspiron.random \
--to=andrea@suse.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).