linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kuznet@ms2.inr.ac.ru
To: ionut@cs.columbia.edu (Ion Badulescu)
Cc: davem@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [UPDATE] Zerocopy patches, against 2.4.1-pre10
Date: Sat, 27 Jan 2001 21:39:44 +0300 (MSK)	[thread overview]
Message-ID: <200101271839.VAA02790@ms2.inr.ac.ru> (raw)
In-Reply-To: <Pine.LNX.4.30.0101261648280.20615-100000@age.cs.columbia.edu> from "Ion Badulescu" at Jan 26, 1 04:55:05 pm

Hello!

> verify this? The only way I can think of is to verify that the checksum
> field is zero initially, correct?

It is not zero. It contains checksum of pseudoheader.


> fits the new Linux model a bit better, as it has one descriptor per
> packet, not one per fragment (like the current implementation).

Yes. Absence of such mode with acenic is big pain in ass.


> tinygrams. A TCP packet whose second fragment is 1-byte long usually goes
> over the wire with the wrong checksum. If the second fragment is 3-byte
> long, it is checksummed correctly (so it's not an even/odd problem).

Seems, this is pretty common bug. At least, perfect checksumming
of chunks with any size and alignment is so big boast of
alteon people, that it is clearly rather exception than rule. 8)8)

I think you have to check for wrong combination of alignment/size and
to call skb_checksum_help() and to disable checksumming if combination
is bad.

Alexey
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

  reply	other threads:[~2001-01-27 18:40 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200101242123.NAA00986@pizda.ninka.net>
2001-01-25  1:40 ` [UPDATE] Zerocopy patches, against 2.4.1-pre10 Andrew Morton
2001-01-25 19:29   ` kuznet
2001-01-25 20:28     ` Ion Badulescu
2001-01-25 20:36       ` kuznet
2001-01-25 20:43     ` David S. Miller
2001-01-25 21:11       ` Ion Badulescu
2001-01-26 19:43         ` kuznet
2001-01-29 22:02         ` David S. Miller
2001-01-25 21:14       ` David S. Miller
2001-01-25 21:29         ` Steve Whitehouse
2001-01-31 16:04           ` Alan Cox
2001-03-11 20:55             ` NBD Fix (attempt #2) Steve Whitehouse
2001-01-25 21:38         ` [UPDATE] Zerocopy patches, against 2.4.1-pre10 David S. Miller
2001-01-26  6:06         ` Ion Badulescu
2001-01-26 13:13         ` David S. Miller
2001-01-26 20:43           ` Ion Badulescu
2001-01-27  0:55             ` Ion Badulescu
2001-01-27 18:39               ` kuznet [this message]
2001-01-27 21:18                 ` Ion Badulescu
2001-01-30  6:02                 ` David S. Miller
2001-01-26  1:27     ` Andrew Morton
2001-01-25  9:29 ` David S. Miller
2001-01-24 21:52 Jonathan Earle
2001-01-24 23:33 ` Peter Samuelson
  -- strict thread matches above, loose matches on Subject: below --
2001-01-24 21:34 Jonathan Earle
2001-01-24 21:45 ` Mathieu Chouquet-Stringer
2001-01-31 22:42   ` Rogerio Brito

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200101271839.VAA02790@ms2.inr.ac.ru \
    --to=kuznet@ms2.inr.ac.ru \
    --cc=davem@redhat.com \
    --cc=ionut@cs.columbia.edu \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).