From: Chris Wedgwood <cw@f00f.org>
To: Jan Rekorajski <baggins@sith.mimuw.edu.pl>,
"David S. Miller" <davem@redhat.com>,
linux-kernel@vger.kernel.org, netdev@oss.sgi.com
Subject: Re: [UPDATE] zerocopy BETA 3
Date: Sun, 25 Feb 2001 16:38:36 +1300 [thread overview]
Message-ID: <20010225163836.A12173@metastasis.f00f.org> (raw)
In-Reply-To: <14998.2628.144784.585248@pizda.ninka.net> <20010223114249.A27608@sith.mimuw.edu.pl>
In-Reply-To: <20010223114249.A27608@sith.mimuw.edu.pl>; from baggins@sith.mimuw.edu.pl on Fri, Feb 23, 2001 at 11:42:49AM +0100
On Fri, Feb 23, 2001 at 11:42:49AM +0100, Jan Rekorajski wrote:
Could you please make a patch with this fix only? Or is it
available somewhere?
--- linux-2.4.2/include/net/ip.h Sun Feb 25 01:15:19 2001
+++ linux-2.4.2+zc-2/include/net/ip.h Sun Feb 25 01:53:52 2001
@@ -188,11 +188,16 @@
extern void __ip_select_ident(struct iphdr *iph, struct dst_entry *dst);
-static inline void ip_select_ident(struct iphdr *iph, struct dst_entry *dst)
+static inline void ip_select_ident(struct iphdr *iph, struct dst_entry *dst, struct sock *sk)
{
- if (iph->frag_off&__constant_htons(IP_DF))
- iph->id = 0;
- else
+ if (iph->frag_off&__constant_htons(IP_DF)) {
+ /* This is only to work around buggy Windows95/2000
+ * VJ compression implementations. If the ID field
+ * does not change, they drop every other packet in
+ * a TCP stream using header compression.
+ */
+ iph->id = (sk ? sk->protinfo.af_inet.id++ : 0);
+ } else
__ip_select_ident(iph, dst);
}
FWIW; I am still seeing _really_ bad throughput on a 10M ethernet
segment between 2.4.2+zc-2 and Windows98 SE. Nobody else has
complained so I guess it is something local (mii-tool for Windows
wouldn't be a bad idea), but if the above doesn't work for you I'd
been keen to know about it.
--cw
next prev parent reply other threads:[~2001-02-25 3:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-02-23 6:59 [UPDATE] zerocopy BETA 3 David S. Miller
2001-02-23 10:42 ` Jan Rekorajski
2001-02-25 3:38 ` Chris Wedgwood [this message]
2001-02-25 3:54 ` Jan Rekorajski
2001-02-26 23:25 ` [UPDATE] zerocopy.. While working on ip.h stuff David S. Miller
2001-02-26 23:47 ` Benjamin C.R. LaHaise
2001-02-27 0:05 ` David S. Miller
2001-02-27 0:11 ` Benjamin C.R. LaHaise
2001-02-27 3:41 ` Michael Peddemors
2001-02-27 3:24 ` Michael Peddemors
2001-02-26 23:46 ` Michael Peddemors
2001-02-26 23:23 ` Andi Kleen
2001-02-26 5:28 ` [UPDATE] zerocopy BETA 3 David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010225163836.A12173@metastasis.f00f.org \
--to=cw@f00f.org \
--cc=baggins@sith.mimuw.edu.pl \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).