From: Erik Mouw <J.A.K.Mouw@ITS.TUDelft.NL>
To: Chris Mason <mason@suse.com>
Cc: Linux kernel mailing list <linux-kernel@vger.kernel.org>,
Nick Pasich <npasich@crash.cts.com>,
reiserfs-list@namesys.com
Subject: Re: [PATCH] Re: reiserfs: still problems with tail conversion
Date: Mon, 26 Feb 2001 12:07:04 +0100 [thread overview]
Message-ID: <20010226120704.A12809@arthur.ubicom.tudelft.nl> (raw)
In-Reply-To: <20010225183201.D866@arthur.ubicom.tudelft.nl> <1136530000.983155244@tiny>
In-Reply-To: <1136530000.983155244@tiny>; from mason@suse.com on Sun, Feb 25, 2001 at 09:40:44PM -0500
On Sun, Feb 25, 2001 at 09:40:44PM -0500, Chris Mason wrote:
> This patch should take care of the other cause for null bytes
> in small files. It has been through a few hours of testing,
> with some of the usual load programs + Erik's code concurrently.
>
> I'll let things run overnight to try and find more bugs. The
> patch is against 2.4.2, and does a few things:
>
> don't dirty the direct->indirect target until all direct items
> have been copied in. Before it was dirtied for each direct item.
>
> make the target up to date before dirtying (it was done after).
>
> don't try to zero the unused part of the target until all bytes
> have been copied. This was the big bug, it was zeroing previously
> copied bytes.
>
> Any testing on non-production machines would be appreciated,
> I'll forward to Linus/Alan once I've gotten more feedback.
Yes, this did the trick, I can't repeat it anymore after a first run.
I'll let my code run for a couple of times to stress the system, but at
first glance the bug seems to be fixed.
Thanks for your efforts,
Erik
--
J.A.K. (Erik) Mouw, Information and Communication Theory Group, Department
of Electrical Engineering, Faculty of Information Technology and Systems,
Delft University of Technology, PO BOX 5031, 2600 GA Delft, The Netherlands
Phone: +31-15-2783635 Fax: +31-15-2781843 Email: J.A.K.Mouw@its.tudelft.nl
WWW: http://www-ict.its.tudelft.nl/~erik/
next prev parent reply other threads:[~2001-02-26 14:34 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-02-23 21:18 reiserfs: still problems with tail conversion Erik Mouw
2001-02-23 22:10 ` Chris Mason
2001-02-23 22:19 ` Erik Mouw
2001-02-24 2:52 ` Michal Gornisiewicz
2001-02-24 4:13 ` Meino Christian Cramer
2001-02-24 8:18 ` thunder7
2001-02-24 19:27 ` Ken Moffat
2001-02-24 20:53 ` Alan Cox
2001-02-25 0:41 ` Chris Mason
2001-02-25 4:21 ` Bernd Eckenfels
2001-02-25 5:41 ` Mike Galbraith
2001-02-25 13:53 ` Alan Cox
2001-02-25 16:37 ` Erik Mouw
2001-02-25 17:32 ` Erik Mouw
2001-02-26 2:40 ` [PATCH] " Chris Mason
2001-02-26 11:07 ` Erik Mouw [this message]
2001-02-26 15:37 ` Erik Mouw
2001-02-26 22:46 ` Ken Moffat
2001-02-25 20:32 ` Chris Mason
2001-02-24 0:34 ` Oliver Teuber
[not found] ` <01022318321302.01755@flash>
2001-02-24 8:40 ` John E. Adams
2001-02-24 15:45 ` Arjan Filius
2001-02-24 16:24 ` [lkml]Re: " thunder7
2001-02-24 17:28 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010226120704.A12809@arthur.ubicom.tudelft.nl \
--to=j.a.k.mouw@its.tudelft.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=mason@suse.com \
--cc=npasich@crash.cts.com \
--cc=reiserfs-list@namesys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).