From: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>,
stefani@lkg.dec.com, linux-kernel@vger.kernel.org
Subject: [PATCH] defxx.c: don't reference skb after passing it to netif_rx
Date: Mon, 26 Feb 2001 20:39:08 -0300 [thread overview]
Message-ID: <20010226203908.E8692@conectiva.com.br> (raw)
In-Reply-To: <20010226203359.D8692@conectiva.com.br>
In-Reply-To: <20010226203359.D8692@conectiva.com.br>; from acme@conectiva.com.br on Mon, Feb 26, 2001 at 08:33:59PM -0300
one more.
Em Mon, Feb 26, 2001 at 08:33:59PM -0300, Arnaldo Carvalho de Melo escreveu:
Hi,
I've just read davem's post at netdev about the brokeness of
referencing skbs after passing it to netif_rx, so please consider applying
this patch. Ah, this was just added to the Janitor's TODO list at
http://bazar.conectiva.com.br/~acme/TODO and I'm doing a quick audit in the
net drivers searching for this, maybe some more patches will follow.
- Arnaldo
--- linux-2.4.2/drivers/net/defxx.c Tue Feb 13 19:15:05 2001
+++ linux-2.4.2.acme/drivers/net/defxx.c Mon Feb 26 22:09:29 2001
@@ -2858,6 +2858,7 @@
skb->dev = bp->dev; /* pass up device pointer */
skb->protocol = fddi_type_trans(skb, bp->dev);
+ bp->rcv_total_bytes += skb->len;
netif_rx(skb);
/* Update the rcv counters */
@@ -2865,8 +2866,6 @@
bp->rcv_total_frames++;
if (*(p_buff + RCV_BUFF_K_DA) & 0x01)
bp->rcv_multicast_frames++;
-
- bp->rcv_total_bytes += skb->len;
}
}
}
prev parent reply other threads:[~2001-02-27 1:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-02-26 23:33 [PATCH] de4x5.c: don't reference skb after passing it to netif_rx Arnaldo Carvalho de Melo
2001-02-26 23:39 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010226203908.E8692@conectiva.com.br \
--to=acme@conectiva.com.br \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=stefani@lkg.dec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).