linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@ns.caldera.de>
To: Wayne.Brown@altec.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: badly punctuated parameter list in `#define' (2.4.3-ac5 and 2.4.4 -pre2)
Date: Thu, 12 Apr 2001 21:31:40 +0200	[thread overview]
Message-ID: <200104121931.VAA02438@ns.caldera.de> (raw)
In-Reply-To: <86256A2C.0068BA0C.00@smtpnotes.altec.com>

In article <86256A2C.0068BA0C.00@smtpnotes.altec.com> you wrote:
>
> When compiling 2.4.3-ac5 (and also 2.4.4-pre2) I get this:
>
> /usr/src/linux-2.4.3-ac5/include/asm/rwsem.h:26: badly punctuated parameter list
>  in `#define'
>
> This appears to be due to some code in rwsem.h that is written for a different
> version of gcc. (I'm still using gcc-2.91.66 as specified in
> Documentation/Changes.)  It works for me if I replace it with the code in the
> section labeled /* old gcc */.  Here's a patch to do that:

So the /* old gcc */ part should probably be enabled based on a define for the
old compiler.  The right ifdef seems to be:

  #if __GNUC__ == 2 && __GNUC_MINOR__ < 95

Could you test it this way?

	Christoph

-- 
Of course it doesn't work. We've performed a software upgrade.

  reply	other threads:[~2001-04-12 19:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-04-12 19:03 Wayne.Brown
2001-04-12 19:31 ` Christoph Hellwig [this message]
2001-04-13 10:39   ` Jamie Lokier
2001-04-13 12:52     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200104121931.VAA02438@ns.caldera.de \
    --to=hch@ns.caldera.de \
    --cc=Wayne.Brown@altec.com \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: badly punctuated parameter list in `#define'\'' (2.4.3-ac5 and 2.4.4 -pre2)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).