From: kuznet@ms2.inr.ac.ru
To: jgarzik@mandrakesoft.com (Jeff Garzik)
Cc: andrewm@uow.edu.au, davem@redhat.COM, linux-kernel@vger.kernel.org
Subject: Re: NETDEV_CHANGE events when __LINK_STATE_NOCARRIER is modified
Date: Mon, 14 May 2001 23:42:46 +0400 (MSK DST) [thread overview]
Message-ID: <200105141942.XAA16515@ms2.inr.ac.ru> (raw)
In-Reply-To: <3B0031A0.25C332D2@mandrakesoft.com> from "Jeff Garzik" at May 14, 1 03:27:28 pm
Hello!
> Each bus should
Not all the device are bound to some "bus".
> Are you talking about his 140k patch?
Yes!
Size of patch and "simplicity" are orthogonal things.
It was simple like potatoe.
> I think a key point of my patch is that drivers now follow the method of
> other kernel drivers: perform all setup necessary, and then register the
> device in a single operation.
Nice. I agreed. I talk about other thing: after applying Andrew's patch
I saw good correct code. After you will fix all the devices, your patch will
be the same 140K or more due to killing refs t dev->name announced
to be illegal. 8)
> After register_foo(dev), all members of
> 'dev' are assumed to be filled in and ready for use. This is not the
> case ....................... using dev->init()...
Sorry? Why?
> Tangent - IMHO having register_netdev call dev->init is ugly and unusual
> compared to other driver APIs in the kernel. Your register function
> should not call out to driver functions, it should just register a new,
> already-set-up device in the subsystem and return.
Provided you teach me some way to generate unique identifiers, different
of device names.
> So you say a fatal bug remains in 2.4.5-pre1? If so please elaborate...
Probably, I am looking into different code, but I found only 15 references
to new interface.
Alexey
next prev parent reply other threads:[~2001-05-14 19:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <15091.23655.488243.650394@pizda.ninka.net>
2001-05-13 18:19 ` NETDEV_CHANGE events when __LINK_STATE_NOCARRIER is modified kuznet
2001-05-14 1:43 ` Andrew Morton
2001-05-14 17:47 ` kuznet
2001-05-14 18:12 ` Jeff Garzik
2001-05-14 18:40 ` kuznet
2001-05-14 19:27 ` Jeff Garzik
2001-05-14 19:42 ` kuznet [this message]
2001-05-14 20:34 ` Jeff Garzik
2001-05-14 23:51 ` Andrew Morton
2001-05-15 9:02 ` kuznet
2001-05-15 11:00 ` Andrew Morton
2001-05-15 11:15 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200105141942.XAA16515@ms2.inr.ac.ru \
--to=kuznet@ms2.inr.ac.ru \
--cc=andrewm@uow.edu.au \
--cc=davem@redhat.COM \
--cc=jgarzik@mandrakesoft.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).