From: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
To: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Cc: Tom Vier <tmv5@home.com>, Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-kernel@vger.kernel.org
Subject: Re: [patch] Re: Linux 2.4.5-ac6
Date: Fri, 8 Jun 2001 18:16:12 +0400 [thread overview]
Message-ID: <20010608181612.A561@jurassic.park.msu.ru> (raw)
In-Reply-To: <20010607212015.A17908@jurassic.park.msu.ru> <Pine.GSO.3.96.1010607193120.16852B-100000@delta.ds2.pg.gda.pl>
In-Reply-To: <Pine.GSO.3.96.1010607193120.16852B-100000@delta.ds2.pg.gda.pl>; from macro@ds2.pg.gda.pl on Thu, Jun 07, 2001 at 08:28:04PM +0200
On Thu, Jun 07, 2001 at 08:28:04PM +0200, Maciej W. Rozycki wrote:
> DU seems to map as low as possible, it would seem.
Yes, I've just checked, starting at 64K...
> Maybe we could just
> do the same for OSF/1 binaries by setting TASK_UNMAPPED_BASE
> appropriately?
No. I've changed in load_aout_binary() set_personality(PER_LINUX) to
set_personality(PER_LINUX_32BIT), and now I have another error.
You will laugh, but...
$ netscape
665:/usr/lib/netscape/netscape-communicator: : Fatal Error: mmap available address is not larger than requested
This happens after
mmap(0x7fdc8000, 40960, PROT_READ|PROT_WRITE|PROT_EXEC, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x40018000
And note, this is the message from loader, not from netscape itself.
So I think my second patch is an easiest solution for now.
Look, compared with the code in Linus' tree:
- it doesn't add any overhead in general case (addr == 0);
- if the specified address is too high and we can't find a free
area above it, we just continue search from TASK_UNMAPPED_BASE
as usual;
- if address is too low, extra cost is only compare and taken branch.
I think it's clean enough.
Ivan.
next prev parent reply other threads:[~2001-06-08 14:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-06-01 11:01 Linux 2.4.5-ac6 Alan Cox
2001-06-01 11:28 ` Alexander Viro
2001-06-01 11:52 ` Alan Cox
2001-06-01 12:23 ` Keith Owens
2001-06-02 2:27 ` Tom Vier
2001-06-04 10:16 ` Maciej W. Rozycki
2001-06-04 17:08 ` [patch] " Ivan Kokshaysky
2001-06-05 15:11 ` Maciej W. Rozycki
2001-06-05 17:41 ` Ivan Kokshaysky
2001-06-05 18:32 ` Maciej W. Rozycki
2001-06-06 5:37 ` Ivan Kokshaysky
2001-06-06 13:09 ` Maciej W. Rozycki
2001-06-06 14:49 ` Jeff Garzik
2001-06-06 17:26 ` Maciej W. Rozycki
2001-06-07 17:48 ` Ivan Kokshaysky
2001-06-07 18:31 ` Maciej W. Rozycki
2001-06-08 10:18 ` jlnance
2001-06-08 17:06 ` Gerhard Mack
2001-06-08 14:18 ` Ivan Kokshaysky
2001-06-07 17:20 ` Ivan Kokshaysky
2001-06-07 18:28 ` Maciej W. Rozycki
2001-06-08 14:16 ` Ivan Kokshaysky [this message]
2001-06-08 16:08 ` Maciej W. Rozycki
2001-06-08 17:23 ` Ivan Kokshaysky
2001-06-09 10:14 ` Ivan Kokshaysky
2001-06-09 18:46 ` Tom Vier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010608181612.A561@jurassic.park.msu.ru \
--to=ink@jurassic.park.msu.ru \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@ds2.pg.gda.pl \
--cc=tmv5@home.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).