From: Michal Jaegermann <michal@harddata.com>
To: Jeff Garzik <jgarzik@mandrakesoft.com>
Cc: linux-kernel@vger.kernel.org, alan@lxorguk.ukuu.org.uk
Subject: Re: Minor "cleanup" patches for 2.4.5-ac kernels
Date: Tue, 12 Jun 2001 20:04:57 -0600 [thread overview]
Message-ID: <20010612200457.A30127@mail.harddata.com> (raw)
In-Reply-To: <20010612183832.A29923@mail.harddata.com> <3B26BBDB.1EF70F79@mandrakesoft.com>
In-Reply-To: <3B26BBDB.1EF70F79@mandrakesoft.com>; from jgarzik@mandrakesoft.com on Tue, Jun 12, 2001 at 09:03:23PM -0400
On Tue, Jun 12, 2001 at 09:03:23PM -0400, Jeff Garzik wrote:
> Michal Jaegermann wrote:
> > --- linux-2.4.5ac/drivers/pci/quirks.c~ Tue Jun 12 16:31:12 2001
> > +++ linux-2.4.5ac/drivers/pci/quirks.c Tue Jun 12 17:13:18 2001
> > @@ -18,6 +18,7 @@
> > #include <linux/pci.h>
> > #include <linux/init.h>
> > #include <linux/delay.h>
> > +#include <linux/sched.h>
> >
> > #undef DEBUG
> >
> > There is no problem if SMP is not configured.
>
> no the better place for this is include/asm-i386/delay.h.
You mean to put "#include <linux/sched.h>" into include/linux/delay.h?
Otherwise this will not help very much on Alpha when I run into
the problem; or other architectures. :-) Works for me and indeed
it may be a better place.
> Otherwise you
> wind up solving the same problem over and over again in each similar
> driver.
'quirks.c' was the only trouble spot which tripped compilation
after changes to it. So I kept my patch local.
> I --just-- went through on Alpha, and included linux/sched.h in
> include/asm-alpha/delay.h. Not an hour ago :)
This was probably this hour when I was looking for that error. :-)
> Then Andrea suggested to
> simply un-inline udelay, which solved the compile problem in an even
> better way. (we cannot un-inline udelay on x86 I think)
How about other architectures? Each will need an individual treatment?
> > --- 2.4.5-ac11/include/linux/binfmts.h Mon Jun 4 14:19:00 2001
> > +++ linux/include/linux/binfmts.h Mon Jun 4 20:24:50 2001
> > @@ -32,6 +32,9 @@ struct linux_binprm{
> > unsigned long loader, exec;
> > };
> >
> > +/* Forward declaration */
> > +struct mm_struct;
> > +
>
> I added this one to the MDK kernel compile. I think it is an 'ac'
> thing, I don't get these warnings on vanilla 2.4.[56]-pre.
Indeed it is. All three actually are (as I wrote). The last one,
if not present, has a very unpleasant effect of drowning compilation
warnings in a flood as wailing happens in a header which is included
mostly everywhere. It is very easy then to miss something where one
should pay a closer attention.
I suggested earlier some other patch for that but Alan apparently
did not like that one. Quite possibly he was right.
Michal
next prev parent reply other threads:[~2001-06-13 2:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-06-13 0:38 Minor "cleanup" patches for 2.4.5-ac kernels Michal Jaegermann
2001-06-13 1:03 ` Jeff Garzik
2001-06-13 2:04 ` Michal Jaegermann [this message]
2001-06-14 13:40 ` Jeff Garzik
2001-06-14 18:05 ` Alan Cox
2001-06-14 18:30 ` Michal Jaegermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010612200457.A30127@mail.harddata.com \
--to=michal@harddata.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jgarzik@mandrakesoft.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).