From: Andrea Arcangeli <andrea@suse.de>
To: Richard Henderson <rth@redhat.com>
Cc: torvalds@transmeta.com, alan@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: 2.4.5 gcc3 build patch
Date: Wed, 13 Jun 2001 02:12:42 +0200 [thread overview]
Message-ID: <20010613021242.E709@athlon.random> (raw)
In-Reply-To: <20010612162733.D26637@redhat.com>
In-Reply-To: <20010612162733.D26637@redhat.com>; from rth@redhat.com on Tue, Jun 12, 2001 at 04:27:33PM -0700
On Tue, Jun 12, 2001 at 04:27:33PM -0700, Richard Henderson wrote:
> We fixed a bug in cv-qualification checking.
>
> timer.c:35: conflicting types for `xtime'
> include/linux/sched.h:540: previous declaration of `xtime'
>
> There's no need for the volatile qualification here. One, being a
> struct it doesn't do any good, and two it's protected by xtime_lock.
wrong, the sec field of xtime is read all the time without any lock.
so xtime can change under you it has to be declared volatile or C
language will screwup. gcc 3.0 effectively spotted a bug in the kernel
that wasn't exporting xtime as volatile.
Right fix is this that I did just about 10 minutes ago after the 3.0
checkout ;)
ftp://ftp.kernel.org/pub/linux/kernel/people/andrea/kernels/v2.4/2.4.6pre2aa2/00_gcc-30-volatile-xtime-1
Andrea
prev parent reply other threads:[~2001-06-13 0:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-06-12 23:27 2.4.5 gcc3 build patch Richard Henderson
2001-06-13 0:12 ` Andrea Arcangeli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010613021242.E709@athlon.random \
--to=andrea@suse.de \
--cc=alan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rth@redhat.com \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).