From: Michal Jaegermann <michal@harddata.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Michal Jaegermann <michal@harddata.com>, linux-kernel@vger.kernel.org
Subject: Re: Minor "cleanup" patches for 2.4.5-ac kernels
Date: Thu, 14 Jun 2001 12:30:16 -0600 [thread overview]
Message-ID: <20010614123016.B11134@mail.harddata.com> (raw)
In-Reply-To: <20010612183832.A29923@mail.harddata.com> <E15AbVD-00053n-00@the-village.bc.nu>
In-Reply-To: <E15AbVD-00053n-00@the-village.bc.nu>; from alan@lxorguk.ukuu.org.uk on Thu, Jun 14, 2001 at 07:05:55PM +0100
On Thu, Jun 14, 2001 at 07:05:55PM +0100, Alan Cox wrote:
> > --- linux-2.4.5ac/drivers/pci/quirks.c~ Tue Jun 12 16:31:12 2001
> > +++ linux-2.4.5ac/drivers/pci/quirks.c Tue Jun 12 17:13:18 2001
> > @@ -18,6 +18,7 @@
> > #include <linux/pci.h>
> > #include <linux/init.h>
> > #include <linux/delay.h>
> > +#include <linux/sched.h>
>
> Ok
Jeff Garzik had some comments here and other, architecture dependent,
propositions.
> >
> > This one is replacing a symbol in sg.c to one which is exported
> > so 'sg.o' can be compiled as a valid module.
>
> Export the right symbol on Alpha ?
I do not see how this one is Alpha specific. Patches from 'ac' series
added one reference to 'simple_strtol' in drivers/scsi/sg.c. Sure, one
more symbol can be exported, but results of this call are used only as a
zero/non-zero flag so an already exported 'simple_strtoul' will serve
instead (or we have an extra export for _one_ call in the whole kernel).
Michal
prev parent reply other threads:[~2001-06-14 18:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-06-13 0:38 Minor "cleanup" patches for 2.4.5-ac kernels Michal Jaegermann
2001-06-13 1:03 ` Jeff Garzik
2001-06-13 2:04 ` Michal Jaegermann
2001-06-14 13:40 ` Jeff Garzik
2001-06-14 18:05 ` Alan Cox
2001-06-14 18:30 ` Michal Jaegermann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010614123016.B11134@mail.harddata.com \
--to=michal@harddata.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).