From: Steven Walter <srwalter@yahoo.com>
To: Josh Myer <jbm@joshisanerd.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix warning in tdfxfb.c
Date: Sat, 16 Jun 2001 15:10:14 -0500 [thread overview]
Message-ID: <20010616151014.A2086@hapablap.dyn.dhs.org> (raw)
In-Reply-To: <20010616133243.A1610@hapablap.dyn.dhs.org> <Pine.LNX.4.21.0106161452270.1755-100000@dignity.joshisanerd.com>
In-Reply-To: <Pine.LNX.4.21.0106161452270.1755-100000@dignity.joshisanerd.com>; from jbm@joshisanerd.com on Sat, Jun 16, 2001 at 02:59:34PM -0500
On Sat, Jun 16, 2001 at 02:59:34PM -0500, Josh Myer wrote:
> It might be better to add a default case to the switch statement below, so
> this symbol doesn't just eat up another 4(8 on some platforms, and i'm
> sure others) bytes of memory unneccesarily.
I'm not quite sure I follow you. The default case should never be
reached, because only the three cases currently present are allowed by
the encapsulating 'if' statement. Even so, how would adding a default
case get rid of the variable or save space some other way?
> anyway, it doesn't really matter. i'd test my hypothesis, but i've got
> people coming over this afternoon =) the driver looks like it might use
> some scrubbing anyway (s!//(.*)$!/\* $1 \*/!...)
Good point. Perhaps I'll prepare a larger patch with this and other
cleanups.
--
-Steven
In a time of universal deceit, telling the truth is a revolutionary act.
-- George Orwell
prev parent reply other threads:[~2001-06-16 20:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-06-16 18:12 [PATCH] fix warning in tdfxfb.c Steven Walter
[not found] ` <E15BKmL-0008Q7-00@the-village.bc.nu>
2001-06-16 18:32 ` Steven Walter
[not found] ` <Pine.LNX.4.21.0106161452270.1755-100000@dignity.joshisanerd.com>
2001-06-16 20:10 ` Steven Walter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010616151014.A2086@hapablap.dyn.dhs.org \
--to=srwalter@yahoo.com \
--cc=jbm@joshisanerd.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).