Re: [PATCH] small patch to ide-tape.c

Re: [PATCH] small patch to ide-tape.c

[Pete Zaitcev]

> This patch adds a missing semicolon that is noticed only if you define
> IDETAPE_DEBUG_LOG_VERBOSE:
> 
> John Guthrie
> guthrie@martnet.com

It makes me curious, why do you need to define
IDETAPE_DEBUG_LOG_VERBOSE?

I fixed some stuff with files not restoring properly
with last block corrupt. Talking with Andre and Gadi now.
What is your problem?

-- Pete

Re: [PATCH] small patch to ide-tape.c

[John Guthrie]

Pete Zaitcev <zaitcev@redhat.com> wrote:
> > This patch adds a missing semicolon that is noticed only if you define
> > IDETAPE_DEBUG_LOG_VERBOSE:
> > 
> > John Guthrie
> > guthrie@martnet.com
> 
> It makes me curious, why do you need to define
> IDETAPE_DEBUG_LOG_VERBOSE?
> 
> I fixed some stuff with files not restoring properly
> with last block corrupt. Talking with Andre and Gadi now.
> What is your problem?

I sent out some posts earlier on this.  To summarize, I have an HP Colorado
5GB IDE tape drive.  I have been able to use mt to move the tape forward, find
out where the tape is positioned, rewind it, etc.  I have also been able to
use tar to write to the tape drive.  When I try to use tar to read from the
tape drive though, I get the following as output:

tar: /dev/ht0: Cannot read: Input/output error
tar: At beginning of tape, quitting now
tar: Error is not recoverable: exiting now

The following also appears in dmesg output when I try to run the tar command:

ide-tape: Reached idetape_chrdev_open
ide-tape: ht0: I/O error, pc =  8, key =  5, asc = 2c, ascq =  0

Willem Riede suggested to me that I try turning IDETAPE_DEBUG_LOG_VERBOSE on
to help with debugging.  That iswhen I ran into this line that as missing a
semicolon.

John Guthrie
guthrie@martnet.com

[PATCH] small patch to ide-tape.c

[John Guthrie]

Hello all,

This patch adds a missing semicolon that is noticed only if you define
IDETAPE_DEBUG_LOG_VERBOSE:

John Guthrie
guthrie@martnet.com

------------------------------CUT HERE-------------------------------------

--- ide-tape.c.orig	Tue Jul  3 18:20:22 2001
+++ ide-tape.c	Tue Jul  3 18:22:41 2001
@@ -1409,7 +1409,7 @@
 		case IDETAPE_WRITE_FILEMARK_CMD:	return("WRITE_FILEMARK_CMD");
 		case IDETAPE_SPACE_CMD:			return("SPACE_CMD");
 		case IDETAPE_INQUIRY_CMD:		return("INQUIRY_CMD");
-		case IDETAPE_ERASE_CMD:			return("ERASE_CMD")
+		case IDETAPE_ERASE_CMD:			return("ERASE_CMD");
 		case IDETAPE_MODE_SENSE_CMD:		return("MODE_SENSE_CMD");
 		case IDETAPE_MODE_SELECT_CMD:		return("MODE_SELECT_CMD");
 		case IDETAPE_LOAD_UNLOAD_CMD:		return("LOAD_UNLOAD_CMD");